Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 211726
Summary: | Review Request: gcstar - Personal collections manager | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Christian Jodar <tian> |
Component: | Package Review | Assignee: | Gérard Milmeister <gemi> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | gemi |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-11-09 11:48:21 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Christian Jodar
2006-10-21 10:58:25 UTC
GCstar is based on GCfilms and will replace it (for the moment both of them are maintained). GCfilms has already been included in Fedora Extras. So the .spec file here is quite similar to the GCfilms one. The main difference is that GCstar includes a man page. Thanks. rpmlint gcstar-0.5.0-1.src.rpm: W: gcstar setup-not-quiet add -q to the %setup macro rpmlint gcstar-0.5.0-1.noarch.rpm E: gcstar only-non-binary-in-usr-lib probably should put the directories in /usr/lib/gcfilms into /usr/share/gcfilms as well and remove /usr/lib/gcfilms The .desktop file references /usr/share/gcstar/icons/gcstar.png which doesn not exist. The vendor for the .deskop file must be "fedora" For FC5+, there is no need for the Req desktop-files-utils, shared-mime-info, see also http://www.fedoraproject.org/wiki/Packaging/ScriptletSnippets?highlight=%28update-desktop-database%29#head-de6770dd9867fcd085a73a4700f6bcd0d10294ef If this issues are also present in gcfilms, they should be taken care of there too. Thank you for your review. I updated .spec and .src.rpm. The new files are here: Spec URL: http://www.gcstar.org/fedora/gcstar.spec SRPM URL: http://www.gcstar.org/fedora/gcstar-0.5.0-2.src.rpm I removed also "BuildRequires: desktop-files-utils" that was not mentioned on the linked page as I supposed it was not needed also from FC5. Concerning the rpmlint error with non binary files, I don't think it is an issue (but I may be wrong and it should be perhaps be discussed on the fedora-extras mailing list). The files are some Perl libraries. So they are not binary files but only some text files. But for upstream package, they should be in the lib directory because it's where it looks for them. Please let me know if this is really blocking and if Ishould initiate a discussion about this. (In reply to comment #3) > I removed also "BuildRequires: desktop-files-utils" that was not mentioned on > the linked page as I supposed it was not needed also from FC5. No, this is needed, at least on FC5. I restored BuildRequires. The files are here: Spec URL: http://www.gcstar.org/fedora/gcstar.spec SRPM URL: http://www.gcstar.org/fedora/gcstar-0.5.0-3.src.rpm So there is only the problem with .pm files in lib directory now. Let me know if you think we should debate about this on the mailing list. /usr/lib should only platform-dependent files. All other support files should go to /usr/share. Also I prefer it to be that wat, I would say, leave it as it is for now (since gcfilms is similar). But it is cetainly worth discussing on fedora-extras-list. It people come to a conclusion, we should change it that way and notify upstream. APPROVED |