Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 212258

Summary:	Review Request: wvs-data - World Vector Shoreline data
Product:	[Fedora] Fedora	Reporter:	Mamoru TASAKA <mtasaka>
Component:	Package Review	Assignee:	Patrice Dumas <pertusus>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	pertusus
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-10-28 18:53:01 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779, 211626

Description Mamoru TASAKA 2006-10-25 20:54:16 UTC

Spec URL: http://www.ioa.s.u-tokyo.ac.jp/~mtasaka/dist/extras/development/SPECS/wvs-data.spec
SRPM URL: http://www.ioa.s.u-tokyo.ac.jp/~mtasaka/dist/extras/development/SRPMS/wvs-data-0.0.20020219-1.src.rpm
Description: 
This package contains World Vector Shoreline data, which can
be used for XTide related applications.

--------------------------------------------------------
This package is split from xtide srpm.

Comment 1 Patrice Dumas 2006-10-25 21:19:39 UTC

* rpmlint gives an ignorable
W: wvs-data no-documentation
* match upstream
56325c8105c7137ced73396f2f2d8221  wvs.tar.bz2
* simple large data package

Please rename the directory with a name without xtide, since it
is not really related to xtide. The most logical would be
to use
%{_datadir}/wvs-data

APPROVED if you do that change.

No need to reupload a src.rpm, just import it right after doing the
change, this is pretty big.


In files, I prefer to add a trailing / for directories, to show
that it is a directory and not a file (not a blocker).

It may be a good idea to add, in a comment in the spec file 
references to the NOAA site:
http://www.ngdc.noaa.gov/mgg/fliers/93mgg01.html
http://www.ngdc.noaa.gov/mgg/global/relief/ETOPO5/BOUNDARY/WVS/
(Not a blocker).

Comment 2 Mamoru TASAKA 2006-10-25 21:34:25 UTC

Well, only spec file is renewed.
http://www.ioa.s.u-tokyo.ac.jp/~mtasaka/dist/extras/development/SPECS/wvs-data.spec
(0.0.20020219-2)

Comment 3 Patrice Dumas 2006-10-25 21:40:12 UTC

Perfect, 
APPROVED

Comment 4 Mamoru TASAKA 2006-10-28 10:22:17 UTC

Well, I have already committed this to FE-devel.

When I finished rebuilding this on FE-5 and -6, I will close
this bug.

Comment 5 Mamoru TASAKA 2006-10-28 18:53:01 UTC

Rebuilt also for FE-5 and 6.

Thank you for reviewing this package. Closing now.

Comment 6 Patrice Dumas 2006-10-28 23:19:13 UTC

You should really remove the %{?dist} from the packages such that
the package isn't reinstalled at each upgrade.

Comment 7 Mamoru TASAKA 2006-10-29 13:14:12 UTC

(In reply to comment #6)
> You should really remove the %{?dist} from the packages such that
> the package isn't reinstalled at each upgrade.

I am proceeding... Please wait.

Comment 8 Mamoru TASAKA 2006-10-30 08:10:28 UTC

Removing %%dist process seems completed.