Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 212916 (DataObj-FormBuilder)
Summary: | Review Request: php-pear-DB-DataObject-FormBuilder - Automatically build HTML_QuickForm objects | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Christopher Stone <chris.stone> |
Component: | Package Review | Assignee: | Jason Tibbitts <j> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | Flags: | wtogami:
fedora-cvs+
|
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-11-21 14:53:28 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 212912, 212915, 212917 | ||
Bug Blocks: | 163779, 212919 |
Description
Christopher Stone
2006-10-30 03:35:50 UTC
The usual no-documentation warning: W: php-pear-DB-DataObject-FormBuilder no-documentation I was browsing the PEAR site and I noticed that there is actually documentation online for this package. I wonder if it wouldn't be reasonable to include a text file with at least some URLs in it: http://pear.reversefold.com/dokuwiki/doku.php?id=pear:db_dataobject_formbuilder http://opensource.21st.de/static/formbuilder/rapidprototyping-kr.pdf * source files match upstream: 0430207937449d635449389ae345854c DB_DataObject_FormBuilder-1.0.0RC5.tgz * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible. License text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (development, x86_64). * package installs properly O rpmlint output is OK. * final provides and requires are sane: php-pear(DB_DataObject_FormBuilder) = 1.0.0 php-pear-DB-DataObject-FormBuilder = 1.0.0-0.1.RC5.fc7 = /bin/sh /usr/bin/pear php-pear(DB_DataObject) php-pear(Date) php-pear(HTML_QuickForm) php-pear(HTML_Table) php-pear(PEAR) * %check is not present; no test suite upstream. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * scriptlets are OK (pear module installation) * code, not content. * no documentation, so no -docs subpackage is necessary. APPROVED Built for devel, thanks for the review. Will ask upstream on status of documentation (should be there since we are approaching 1.0.0 release). Branch Package CVS Request ======================= Package Name: php-pear-DB-DataObject-FormBuilder Short Description: Automatically build HTML_QuickForm objects Owners: chris.stone Branches: EL-5 InitialCC: |