Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 212917 (DB-DataObject)

Summary:	Review Request: php-pear-DB-DataObject - An SQL Builder, Object Interface to Database Tables
Product:	[Fedora] Fedora	Reporter:	Christopher Stone <chris.stone>
Component:	Package Review	Assignee:	Jason Tibbitts <j>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	Flags:	jwboyer: fedora-cvs+
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-11-21 14:34:05 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779, 212916

Description Christopher Stone 2006-10-30 03:51:35 UTC

Spec URL: http://tkmame.retrogames.com/fedora-extras/php-pear-DB-DataObject.spec
SRPM URL: http://tkmame.retrogames.com/fedora-extras/php-pear-DB-DataObject-1.8.4-1.src.rpm

Description:
DataObject performs 2 tasks:
1. Builds SQL statements based on the objects vars and the builder methods.
2. acts as a datastore for a table row.

The core class is designed to be extended for each of your tables so that you
put the data logic inside the data classes. Included is a Generator to make
your configuration files and your base classes.

Comment 1 Jason Tibbitts 2006-11-15 18:45:55 UTC

Something's odd with the changelog entry; it shows version 1.0.0-0.1.RC5 but the
package version is 1.8.4.  This causes an rpmlint complaint:
W: php-pear-DB-DataObject incoherent-version-in-changelog 1.0.0-0.1.RC5 1.8.4-1.fc7

There's also this:

E: php-pear-DB-DataObject non-executable-script
/usr/share/pear/DB/DataObject/createTables.php 0644

I think this is actually an end-user executable.  Should it really be buried
under /usr/share, or should it be in /usr/bin?

* source files match upstream:
   770c44d243066340d639b063235dcc02  DB_DataObject-1.8.4.tgz
* package meets naming and packaging guidelines.
X The spec is fine except for the changelog.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
X rpmlint has valid complaints.
* final provides and requires are sane:
   php-pear(DB_DataObject) = 1.8.4
   php-pear-DB-DataObject = 1.8.4-1.fc7
  =
   /bin/sh
   /usr/bin/pear
   php-pear(DB)
   php-pear(Date)
   php-pear(MDB2)
   php-pear(PEAR)
   php-pear(Validate)
* %check is not present; no test suite upstream.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
? not sure about file permissions.
* scriptlets are OK (pear module installation).
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

Comment 2 Christopher Stone 2006-11-17 18:40:16 UTC

I have moved the createTables script to %{_bindir} and created a link to its old
location because the documentation says to find it there.

The version number was a copy&paste error on my part from the FormBuilder package.

SPEC: http://tkmame.retrogames.com/fedora-extras/php-pear-DB-DataObject.spec
SRPM:
http://tkmame.retrogames.com/fedora-extras/php-pear-DB-DataObject-1.8.4-2.src.rpm

%changelog
* Fri Nov 17 2006 Christohper Stone <chris.stone> 1.8.4-2
- Fix version number in %%changelog
- Add versioned Requires
- Move createTables script to %%{_bindir}

Comment 3 Jason Tibbitts 2006-11-18 02:02:09 UTC

Looks good to me; rpmlint is quiet now.  I'm not really sure about the symlink
(I'd rather just ignore or patch the documentation) but I don't think it hurts
anything.

APPROVED

Comment 4 Christopher Stone 2006-11-21 14:34:05 UTC

Build on devel succeeded.  Thanks for the review.

Comment 5 Christopher Stone 2007-04-24 00:27:10 UTC

Branch Package CVS Request
=======================
Package Name: php-pear-DB-DataObject
Short Description: An SQL Builder, Object Interface to Database Tables
Owners: chris.stone
Branches: EL-5
InitialCC: