Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 213906
Summary: | Review Request: Pound - a reverse proxy and load balancer | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Ruben Kerkhof <ruben> |
Component: | Package Review | Assignee: | Aurelien Bompard <gauret> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | lkundrak |
Target Milestone: | --- | Flags: | gwync:
fedora-cvs+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-11-14 18:44:39 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Ruben Kerkhof
2006-11-03 18:14:44 UTC
This is my first package, and I'm looking for a sponsor. Needswork : - Do not repeat the name in the Summary - Please create an init script for pound (you can base it on /etc/init.d/transparent-proxying in the squidGuard package for example) - Please make a default config file for /etc/pound.cfg, with a very basic setup (like the second example in the pound(8) man page), but with the control socket and running as a different user -> This implies that you create a directory for Pound's control sockets, for example /var/lib/pound, and that you own it in the rpm -> It also implies that you create a pound user in %pre, see the Zope package for an example) Possible improvements: - Generate a dummy SSL cert in /etc/pki/tls/certs/pound.pem, you can look at the %post script in the openldap-servers package for a way to do it. - Add an SELinux policy, but that's a bit more complicated Thanks for the review Aurelien. I've added everything you asked, except for the SELinux policy. Upstream changed to 2.1.6 in the meantime, so I did as well. http://rubenkerkhof.com/packages/pound/Pound.spec http://rubenkerkhof.com/packages/pound/Pound-2.1.6-1.src.rpm Regards, Ruben Review for release 1: * RPM name is OK * Source Pound-2.1.6.tgz is the same as upstream * This is the latest version * Builds fine in mock * File list looks OK * Config files of Pound looks OK * Works fine Minor: * rpmlint says "macro-in-%changelog". Please replace %post with %%post to avoid warning. * Please replace /usr/sbin with %{_sbindir} in Requires(pre). APPROVED You can now go on with the sponsorship procedure : http://fedoraproject.org/wiki/Extras/Contributors#GetAFedoraAccount Ok, I'll do that. Created a new package with the above errors fixed. http://rubenkerkhof.com/packages/pound/Pound-2.1.6-1.src.rpm Sorry, wrong link. It's at http://rubenkerkhof.com/packages/pound/Pound-2.1.6-2.src.rpm and the updated spec: http://rubenkerkhof.com/packages/pound/Pound.spec Package Change Request ====================== Package Name: Pound New Branches: epel7 Owners: lkundrak wolfy The EL-6 branch maintainer (wolfy) did not respond to private mails, IRC, a public non-responsive maintainer call via fedora-devel list, nor does his sponsor know a way to contact him) :( Adding him a as a co-maint so that he can step in if he's active again. Git done (by process-git-requests). |