Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 214024 (perl-Net-DBus)
Summary: | Review Request: perl-Net-DBus - Net::DBus Perl module | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Chris Weyl <cweyl> |
Component: | Package Review | Assignee: | Jason Tibbitts <j> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | Flags: | j:
fedora-cvs+
|
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://search.cpan.org/dist/Net-DBus/ | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-11-21 18:54:02 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Chris Weyl
2006-11-04 20:22:11 UTC
Update to 0.33.4. SRPM URL: http://home.comcast.net/~ckweyl/perl-Net-DBus-0.33.4-1.fc6.src.rpm SPEC URL: http://home.comcast.net/~ckweyl/perl-Net-DBus.spec Hmm, this fails to build in mock for me: + /usr/bin/perl Makefile.PL INSTALLDIRS=vendor 'OPTIMIZE=-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic' could not run 'pkg-config' to determine compiler/linker flags for dbus library: No such file or directory error: Bad exit status from /var/tmp/rpm-tmp.26604 (%build) Looks like dbus-devel is missing a dependency on pkgconfig. Until it gets one, you'll need to add BR: pkgconfig yourself. Getting past that, the tests fail all over the place because XML::Twig is missing. Adding that, one of the tests still fails: t/30-server.....................process 23518: Applications must not close shared connections - see dbus_connection_close() docs. This is a bug in the application. /lib64/libdbus-1.so.3 [0x2aaaac4dcb1c] /lib64/libdbus-1.so.3 [0x2aaaac4dc1d9] /lib64/libdbus-1.so.3 [0x2aaaac4d1fea] /builddir/build/BUILD/Net-DBus-0.33.4/blib/arch/auto/Net/DBus/DBus.so(XS_Net__DBus__Binding__C__Connection_dbus_connection_disconnect+0x1ca) [0x2aaaac28edda] /usr/lib64/perl5/5.8.8/x86_64-linux-thread-multi/CORE/libperl.so(Perl_pp_entersub+0x3f6) [0x2aaaaad56916] /usr/lib64/perl5/5.8.8/x86_64-linux-thread-multi/CORE/libperl.so(Perl_runops_standard+0xe) [0x2aaaaad501de] /usr/lib64/perl5/5.8.8/x86_64-linux-thread-multi/CORE/libperl.so(perl_run+0x30a) [0x2aaaaacfe03a] /usr/bin/perl(main+0xfc) [0x40179c] /lib64/libc.so.6(__libc_start_main+0xf4) [0x2aaaabf21924] /usr/bin/perl [0x401609] dubious Test returned status 0 (wstat 6, 0x6) DIED. FAILED tests 9-11 Failed 3/11 tests, 72.73% okay I'm not sure what to do from here. An FC5 build does pass but I'm not set up to do FC6 builds yet. (In reply to comment #2) > Hmm, this fails to build in mock for me: > > + /usr/bin/perl Makefile.PL INSTALLDIRS=vendor 'OPTIMIZE=-O2 -g -pipe -Wall > -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 > -m64 -mtune=generic' > could not run 'pkg-config' to determine compiler/linker flags for dbus library: > No such file or directory > error: Bad exit status from /var/tmp/rpm-tmp.26604 (%build) > > Looks like dbus-devel is missing a dependency on pkgconfig. Until it gets one, > you'll need to add BR: pkgconfig yourself. Added. Also filed a bug against the dbus package on this: bug 215346. > Getting past that, the tests fail all over the place because XML::Twig is > missing. Adding that, one of the tests still fails: > > t/30-server.....................process 23518: Applications must not close > shared connections - see dbus_connection_close() docs. This is a bug in the > application. > /lib64/libdbus-1.so.3 [0x2aaaac4dcb1c] > /lib64/libdbus-1.so.3 [0x2aaaac4dc1d9] > /lib64/libdbus-1.so.3 [0x2aaaac4d1fea] > > /builddir/build/BUILD/Net-DBus-0.33.4/blib/arch/auto/Net/DBus/DBus.so(XS_Net__DBus__Binding__C__Connection_dbus_connection_disconnect+0x1ca) > [0x2aaaac28edda] > > /usr/lib64/perl5/5.8.8/x86_64-linux-thread-multi/CORE/libperl.so(Perl_pp_entersub+0x3f6) > [0x2aaaaad56916] > > /usr/lib64/perl5/5.8.8/x86_64-linux-thread-multi/CORE/libperl.so(Perl_runops_standard+0xe) > [0x2aaaaad501de] > > /usr/lib64/perl5/5.8.8/x86_64-linux-thread-multi/CORE/libperl.so(perl_run+0x30a) > [0x2aaaaacfe03a] > /usr/bin/perl(main+0xfc) [0x40179c] > /lib64/libc.so.6(__libc_start_main+0xf4) [0x2aaaabf21924] > /usr/bin/perl [0x401609] > dubious > Test returned status 0 (wstat 6, 0x6) > DIED. FAILED tests 9-11 > Failed 3/11 tests, 72.73% okay > > I'm not sure what to do from here. An FC5 build does pass but I'm not set up to > do FC6 builds yet. Hrm, that's odd. (XML::Twig added, as well.) I'm building this on a FC6/x86_64 box, and not only does this test pass but I've used it to interact with dnsmasq... I'll try building it in mock over here and taking a peek at the buildlog. Maybe it's silently depending on something and almost as silently failing? Ok, I found a FC5 box and build it there... with the additional BR's, no problem. I also built it under mock for fc5&6 (i386)... All tests passed cleanly, so I'm not quite sure what happened above. SRPM URL: http://home.comcast.net/~ckweyl/perl-Net-DBus-0.33.4-2.fc6.src.rpm SPEC URL: http://home.comcast.net/~ckweyl/perl-Net-DBus.spec The point was that it fails to build in rawhide. I tested it on FC5 and it was fine; I was unable to test on FC6 but I am not surprised to see that it works. Failure to work on rawhide is certainly not a blocker, but you should know up front that the code is buggy and could fail at pretty much any time if Red Hat see a need to update DBUS in FC6. I'll check out the new packages. Ahh, rawhide. I missed that, somehow. The module appears to be actively maintained, and the author has been fairly responsive when I've filed issues against it. I'm not worried about there being dbus support in this module to match rawhile by the time fc7 rolls around. I spent a bit of time to get FC6 builds working, and builds on FC6 as well as FC5 are fine: All tests successful, 48 subtests skipped. Files=17, Tests=710, 5 wallclock secs ( 2.44 cusr + 0.44 csys = 2.88 CPU) So, rawhide builds are broken (due to problems with the packaged software, not with rawhide), but that's not a blocker. APPROVED Note that a test update which rebases FC6 to dbus 1.0.1 has just been released, so I expect rawhide brokenness will become a much more urgent issue. Looks like in this case the testsuite (namely 30-server.t) is broken, rather than the module itself: http://rt.cpan.org/Public/Bug/Display.html?id=22850 I guess you can just delete that test so that the package will build properly. CVS is back up now, so check in when you like. Done! Thanks for the review :) Package Change Request ====================== Package Name: perl-Net-DBus New Branches: EL-6 Owners: mmaslano bochecha InitialCC: perl-sig We need an ack from the Fedora maintainer here, or reference to somewhere that he's granted some kind of blanket permission. He's not listed on http://fedoraproject.org/wiki/EPEL/ContributorStatusNo but I see plenty of requests to branch his packages. If he stated his wishes there things would be a bit simpler. Hm, I forgot mentioned that maintainer of this package is not around and we (Perl SIG) are taking care about his packages: https://fedorahosted.org/fesco/ticket/507#comment:7 Sadly, there's no chance maintain it as a group, so we solved it this way. Git done (by process-git-requests). |