Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 214057 (scummvm-bass)
Summary: | Review Request: beneath-a-steel-sky - Beneath a Steel Sky - Adventure Game | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Hans de Goede <hdegoede> |
Component: | Package Review | Assignee: | Christopher Stone <chris.stone> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | ||
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-11-09 19:34:30 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 214055 | ||
Bug Blocks: | 163779 |
Description
Hans de Goede
2006-11-05 08:25:51 UTC
Shouldn't this package Obsolete/Providess "bass" from Livna? I see no bass in livna, atleast not for the development branch. It's available for FC5: http://rpm.livna.org/fedora/5/i386/repodata/repoview/bass-0-0-7.20030801.lvn5.html And some people such as myself still have it installed. That is, an upgrade to FC6 or rawhide does not necessarily remove the bass package. Therefore, I think this package should Obsolete/Provides bass. I will do a formal review later today, so hold off on fixing this until I've finished the formal review incase I spot something else. ==== REVIEW CHECKLIST ==== - rpmlint output W: beneath-a-steel-sky no-%build-section rpmlint says you should add this section even if empty. See rpmlint -I no-%build-section. I tend to agree. While it might not make a difference now (no debuginfo package is built but we dont care) there may be something in the future which checks for this and there is no harm in adding it, so unless you have a specific technical reason to comment it, id say just uncomment it. - package named according to package naming guidelines (although a provides bass might make it easier to install) - spec filename matches package %{name} - package meets packaging guidelines - package is licensed as "Distributable" FOR FURTHER DISCUSSION ON DISTRIBUTION RIGHTS SEE: https://www.redhat.com/archives/fedora-extras-list/2006-November/msg00030.html - License file included in %doc - spec written in American english - spec file is legible - sources match upstream (however source0 location needs fixing) cb968b4cfdde8491069915bf15d275b3 BASS-Floppy.zip - package successfully compiles and builds on FC5 X86_64 - all dependencies listed in BR - no locales - no shared libraries - package is not relocatable - package owns all directories it creates - no duplicates in %files - file permissions set properly - package has proper %clean section - macro usage is consistent - package contains permissible content - no large documentation - no header files or static libraries - no pkgconfig files - no devel subpackage required - no .la files - package contains proper .desktop file - package does not own files or directories owned by other packages ==== MUST ==== - Change location of Source0, this file is *NOT* located on sourceforge ==== SHOULD ==== - Add Obsolete/Provides for "bass" - Uncomment %build - Add in a comment above the License tag the URL pointing to the discussion on the distribution: https://www.redhat.com/archives/fedora-extras-list/2006-November/msg00010.html (In reply to comment #4) > ==== MUST ==== > - Change location of Source0, this file is *NOT* located on sourceforge > > ==== SHOULD ==== > - Add Obsolete/Provides for "bass" > - Uncomment %build > - Add in a comment above the License tag the URL pointing to the discussion on > the distribution: > https://www.redhat.com/archives/fedora-extras-list/2006-November/msg00010.html > Thanks! All fixed / done, new version is here: Spec URL: http://people.atrpms.net/~hdegoede/beneath-a-steel-sky.spec SRPM URL: http://people.atrpms.net/~hdegoede/beneath-a-steel-sky-0.0348-2.src.rpm All MUST and SHOULD items fixed. APPROVED. Thanks! Imported and Build, closing. |