Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 214091 (scummvm-bass-CD)
Summary: | Review Request: beneath-a-steel-sky-cd - Beneath a Steel Sky - Adventure Game - CD version | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Hans de Goede <hdegoede> |
Component: | Package Review | Assignee: | Christopher Stone <chris.stone> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | ||
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-11-10 08:47:48 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 214055 | ||
Bug Blocks: | 163779 |
Description
Hans de Goede
2006-11-05 17:15:36 UTC
==== REVIEW CHECKLIST ==== - rpmlint output W: beneath-a-steel-sky-cd no-%build-section okay, but no harm in enabling %build either - spec file named according to package naming guidelines (but a provides bass-cd would make it easier to install) - spec filename matches %{name} - package meets packaging guidelines - licensed as distributable, see https://www.redhat.com/archives/fedora-extras-list/2006-November/msg00030.html - License file included in %doc - spec written in American english - spec file is legible - sources match upstream 1d4401cd663715332abe8bb5431e356d bass-cd-1.2.zip - package successfully compiles and builds on FC5 X86_64 - all dependencies listed in BR - no locales - no shared libraries - package is not relocatable - package owns all directories it creates - no duplicates in %files - file permissions set properly - package has proper %clean section - macro usage is consistent - package contains permissible content - no large documentation - no header files or static libraries - no pkgconfig files - no devel subpackage required - no .la files - package contains proper .desktop file - package does not own files or directories owned by other packages APPROVED ==== SHOULD ==== - uncomment %build to make rpmlint happy - add Provides: bass-cd for easier commandline installs - add comment above license pointing to distribution discussions on f-e-l (In reply to comment #1) > ==== SHOULD ==== > - uncomment %build to make rpmlint happy Done > - add Provides: bass-cd for easier commandline installs Not done, I deliberately choose the long name as bass is a much to generic name, giving no information about the package contents and leading to potential namespace conflicts. > - add comment above license pointing to distribution discussions on f-e-l Done. Imported and build. Thanks for the review! |