Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 214266 (perl-Moose-Policy)
Summary: | Review Request: perl-Moose-Policy - Moose-mounted police | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Chris Weyl <cweyl> |
Component: | Package Review | Assignee: | Jason Tibbitts <j> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | ||
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://search.cpan.org/dist/Moose-Policy/ | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-11-13 17:30:05 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Chris Weyl
2006-11-06 20:26:59 UTC
I know that's what the documentation says, but the %description is a bit suboptimal. How about "Specify project-wide or site-wide Moose meta-policy"? Not that it makes much more sense, but it at least describes what the module does instead of making it sound as if the software joins your computer to the RCMP computing facilities or something. But I'll leave that up to you. * source files match upstream: 11b2e835e4b97563c4e459475bf9df90 Moose-Policy-0.02.tar.gz * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible. License text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * rpmlint is silent. * final provides and requires are sane: perl(Moose::Policy) = 0.02 perl(Moose::Policy::FollowPBP) perl(Moose::Policy::FollowPBP::Attribute) perl(Moose::Policy::JavaAccessors) perl(Moose::Policy::JavaAccessors::Attribute) perl(Moose::Policy::SingleInheritence) perl(Moose::Policy::SingleInheritence::MetaClass) perl-Moose-Policy = 0.02-1.fc7 = perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(Moose) perl(Scalar::Util) perl(constant) perl(strict) perl(warnings) * %check is present and all tests pass: All tests successful. Files=9, Tests=95, 2 wallclock secs ( 2.04 cusr + 0.20 csys = 2.24 CPU) * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. APPROVED Summary updated -- RCMP has no jurisdition here ;) Imported and building for devel; branches requested for FC5&6. Thanks for the review! |