Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 214730
Summary: | Review Request: pungi - Distribution compose tool | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Jesse Keating <jkeating> |
Component: | Package Review | Assignee: | Patrice Dumas <pertusus> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | dcantrell, dennis, tdawson |
Target Milestone: | --- | Flags: | gwync:
fedora-cvs+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-11-17 14:28:34 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Jesse Keating
2006-11-09 01:48:07 UTC
* name right * follow packaging guidelines * match uptream 6fab9b1b9979aa59b9db5880abfe6136 pungi-0.1.0.tar.gz * sane provides: Provides: config(pungi) = 0.1.0-1 * specfile simple and legible * %files section right * rpmlint says: E: pungi non-executable-script /usr/lib/python2.4/site-packages/pypungi/pungi.py 0644 E: pungi non-executable-script /usr/lib/python2.4/site-packages/pypungi/splittree.py 0644 E: pungi non-executable-script /usr/lib/python2.4/site-packages/pypungi/gather.py 0644 This is ignorable, as you explained above. However wouldn't it make sense to have wrapper around those scripts, named for example pungi-gather or the like, wouldn't it make sense to call them independently? The comment about wrappers is not a blocker, so it is APPROVED Maybe you coule let one day for other reviewers to comment on before importing, such that other people have time to raise concerns. A wrapper doesn't quite make sense, since these are python modules. If you wanted just the functionality of gather, you'd probably use yumdownloader or repotrack instead, or you'd import the pypungi.gather module into your python script and use it there. For pypungi.pungi, there is a bit more of a chance of wanting to run it standalone, but since it is a module, you can do that (: Anyconcerns raised can be fixed once I bring it in. Built for devel, branch for FC-6 requested. (In reply to comment #4) > A wrapper doesn't quite make sense, since these are python modules. If you > wanted just the functionality of gather, you'd probably use yumdownloader or > repotrack instead, or you'd import the pypungi.gather module into your python > script and use it there. For pypungi.pungi, there is a bit more of a chance of > wanting to run it standalone, but since it is a module, you can do that (: Right. Shouldn't this bug be closed now? Whoops, I was waiting for the push, that happened. Jesse: I don't see this package in owners.list. Can you please add it? See: http://fedoraproject.org/wiki/Extras/Contributors#head-f6f080b4c48fe519c98a29364a740953f90179e7 Package Change Request ====================== Package Name: pungi New Branches: epel7 Owners: tdawson Git done (by process-git-requests). The proper procedure for branching a package for epel has not been followed and the request for the epel7 should never have been approved. |