Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 214872 (Ri-li)

Summary:	Review Request: Ri-li - Arcade game where you drive a toy wood engine
Product:	[Fedora] Fedora	Reporter:	Hans de Goede <hdegoede>
Component:	Package Review	Assignee:	Christopher Stone <chris.stone>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-11-14 07:34:17 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779

Description Hans de Goede 2006-11-09 20:14:47 UTC

Spec URL: http://people.atrpms.net/~hdegoede/Ri-li.spec
SRPM URL: http://people.atrpms.net/~hdegoede/Ri-li-2.0.0-1.fc7.src.rpm
Description:
You drive a toy wood engine in many levels and you must collect all the coaches
to win. Full-featured: 18 languages, Colorful animated wood engine, 50 levels,
3 beautiful music tracks and many sound effects.

Comment 1 Christopher Stone 2006-11-14 02:26:59 UTC

==== REVIEW CHECKLIST ====
- rpmlint output clean
- package named according to package naming guidelines
- spec filename matches %{name}
- package meets packaging guidelines
- package licensed with open source compatible license
- license matches actual license
- license file included in %doc
- spec written in American english
- spec legible
- sources match upstream
e6dfa35616f5c84eb14ff82517cea796  Ri-li-2.0.0.tar.bz2
- package successfully compiles and builds on FC6 x86_64
- all build dependencies are listed in BR
- package does not use locales
- no shared libraries
- package is not relocatable
- package owns all directories it creates
- no duplicates in %files
- file permissions set properly
- contains proper %clean
- macro usage consistent
- contains code
- no large documentation files
- %doc does not affect runtime
- no header files or static libraries
- no pkgconfig files
- no need for devel subpackage
- no .la files
- contains proper .desktop file
- package does not own files or directories owned by other packages

APPROVED

==== SHOULD ====
- Remove SDL-devel from BR, SDL_Mixer-devel should pick it up

Comment 2 Hans de Goede 2006-11-14 07:34:17 UTC

(In reply to comment #1)
> 
> ==== SHOULD ====
> - Remove SDL-devel from BR, SDL_Mixer-devel should pick it up
> 

Done.

Thanks for the review, imported and build, closing.