Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 214966

Summary:	Review Request: panelfm - Quick File Manager Applet
Product:	[Fedora] Fedora	Reporter:	Mamoru TASAKA <mtasaka>
Component:	Package Review	Assignee:	Parag AN(पराग) <panemade>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	panemade
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-11-11 14:38:47 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779

Description Mamoru TASAKA 2006-11-10 11:09:09 UTC

Spec URL: http://www.ioa.s.u-tokyo.ac.jp/~mtasaka/dist/extras/development/SPECS/panelfm.spec
SRPM URL: http://www.ioa.s.u-tokyo.ac.jp/~mtasaka/dist/extras/development/SRPMS/panelfm-1.1-1.src.rpm
Description: 
PanelFM is a GNOME applet that provides quick access to the file system. It
uses popup menus to display files and directories. Multiple root points can be
defined for the main menu by creating a .panelfmrc containing a list of root
points, one on each line. Each root point must be an absolute path name.

Comment 1 Mamoru TASAKA 2006-11-10 11:14:53 UTC

Oops...
http://www.ioa.s.u-tokyo.ac.jp/~mtasaka/dist/extras/development/SPECS/panelfm.spec
http://www.ioa.s.u-tokyo.ac.jp/~mtasaka/dist/extras/development/SRPMS/panelfm-1.1-2.src.rpm

* Fri Nov 10 2006 Mamoru Tasaka <mtasaka.u-tokyo.ac.jp> - 1.1-2
- Change BuildRoot

Comment 2 Parag AN(पराग) 2006-11-11 09:44:16 UTC

Nice application will take this for official review.

Comment 3 Parag AN(पराग) 2006-11-11 14:04:41 UTC

Review:
+ package builds in mock (development i386) for FC6.
+ rpmlint is silent for RPM and SRPM.
+ source files match upstream.
5a18f0beba718d6efaace22ed13c1b9e  panelfm.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written but NOT properly indented.
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.  License text included in package.
+ %doc is small; no -doc subpackage required.
+ %doc does not affect runtime.
+ COPYING included in %doc.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc files.
+ no -devel subpackage exists
+ no .la files.
+ no translations available
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ GUI related pannel applet application
APPROVED.

Comment 4 Parag AN(पराग) 2006-11-11 14:06:20 UTC

Don't Forget to CLOSE this bug after you build package

Comment 5 Mamoru TASAKA 2006-11-11 14:38:47 UTC

Well,
* Build for FE-devel succeeded.
* SyncNeeded is requested for FE-6, FE-5.

Now I close this bug as CLOSED NEXTRELEASE.
Thank you for reviewing and approving this package!!