Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 214985

Summary:	Review Request: pachi - Pachi El Marciano - Platform Game
Product:	[Fedora] Fedora	Reporter:	Hans de Goede <hdegoede>
Component:	Package Review	Assignee:	Michel Alexandre Salim <michel.salim>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-11-11 08:05:30 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779

Description Hans de Goede 2006-11-10 14:27:54 UTC

Spec URL: http://people.atrpms.net/~hdegoede/pachi.spec
SRPM URL: http://people.atrpms.net/~hdegoede/pachi-1.0-1.src.rpm
Description:
Pachi El Marciano is a cool 2D platform game inspired by the likes of
Manic Miner, Jet Set Willy, and more from the '80s.

Comment 1 Michel Alexandre Salim 2006-11-10 21:57:58 UTC

Will do a full review later this evening, but quick question: why is the Pachi
binary SUID root? I've not had time to test it much, but the game starts and
acts normally when I removed its SUID bit.

(one rpmlint error on the binary from this)

Comment 2 Hans de Goede 2006-11-10 22:45:09 UTC

It isn't suid root, its sgid games, unless something has gone wrong.

Comment 3 Michel Alexandre Salim 2006-11-11 01:24:53 UTC

Almost done - building my mock cache so I can rebuild the package in mock. Last
question: where is ImageMagick used in the build process?

MUST:
rpmlint OK
spec name OK
license OK
spec language OK
spec readability OK
source verification OK
compilation (x86_64) OK
BuildRequires OK
files & directory ownerships OK

SHOULD:
icon cache updated on post & postun OK

GAMES:
- SGID dropped once score file opened OK

Comment 4 Michel Alexandre Salim 2006-11-11 05:54:10 UTC

Package works OK in mock.

APPROVED (though I'm still curious where ImageMagick is used)

Comment 5 Hans de Goede 2006-11-11 08:05:30 UTC

ImageMagick is needed for the convert command, which is used to convert the .ico
file to a png file.

Thanks for the review! Imported and build, closing.