Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 215564
Summary: | Review Request: bdock - Beryl project's replacement windowmaker dock | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Jarod Wilson <jarod> |
Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | martin.sourada |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-11-21 20:55:38 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 209259 | ||
Bug Blocks: | 163779 |
Description
Jarod Wilson
2006-11-14 17:21:54 UTC
You should probably fix this rpmlint output: E: bdock zero-length /usr/share/doc/bdock-0.1.2/README E: bdock zero-length /usr/share/doc/bdock-0.1.2/ChangeLog (In reply to comment #1) > You should probably fix this rpmlint output: > E: bdock zero-length /usr/share/doc/bdock-0.1.2/README > E: bdock zero-length /usr/share/doc/bdock-0.1.2/ChangeLog Done. http://wilsonet.com/packages/beryl/bdock-0.1.2-2.fc6.src.rpm New build with trimmed-down BR: (needs beryl-core-devel >= 0.1.2-5). http://wilsonet.com/packages/beryl/bdock-0.1.2-3.fc6.src.rpm Well, one question: * /usr/share/pixmaps/clip.tiff /usr/share/pixmaps/defaultAppIcon.xpm /usr/share/pixmaps/tile.tiff - I don't know well about this package, however, source codes include: --------------------------------------------------- ./src/Makefile.am:INCLUDES=@BDOCK_CFLAGS@ -DPIXMAPDIR='"$(datadir)/bdock/"' ./src/main.c: bdock_tile_set_bg_from_file(bt,PIXMAPDIR "tile.tiff"); ./src/main.c: gdk_pixbuf_new_from_file(PIXMAPDIR "defaultAppIcon.xpm",NULL); (and etc) --------------------------------------------------- However, all the image files are installed under /usr/share/pixmaps. Is this correct? Hrm, haven't actually run this code, just packaged it on request... In beryl svn trunk, the pixmaps Makefile has been converted to install in /usr/share/bock instead of /usr/share/pixmaps, so I've patched accordingly: http://wilsonet.com/packages/beryl/bdock-0.1.2-4.fc6.src.rpm Okay. ---------------------------------------------- This package (bdock) is APPROVED. |