Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 215865 (Zim)
Summary: | Review Request: Zim - Desktop wiki & notekeeper | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Chris Weyl <cweyl> |
Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | robinlee.sysu |
Target Milestone: | --- | Flags: | kevin:
fedora-cvs+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://zoidberg.student.utwente.nl/zim/index.shtml | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-11-21 18:54:59 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Chris Weyl
2006-11-16 04:03:47 UTC
I did mock build for FC7 devel i386 and got following in build.log Creating custom builder _build/lib/My/Builder.pm in _build/lib/My WARNING: the following files are missing in your kit: lib/Zim/Win32.pm Please inform the author. AND WARNING: You don't seem to have a mime-info database. The shared-mime-info package is available from http://freedesktop.org/wiki/Software_2fshared_2dmime_2dinfo rpmlint on noarch rpm is not silent Got rpmlint warning on RPM W: Zim hidden-file-or-dir /usr/share/zim/doc/.zim.config The file or directory is hidden. You should see if this is normal, and delete it from the package if not. (In reply to comment #1) > I did mock build for FC7 devel i386 and got following in build.log > Creating custom builder _build/lib/My/Builder.pm in _build/lib/My > WARNING: the following files are missing in your kit: > lib/Zim/Win32.pm > Please inform the author. This is normal and expected -- we delete lib/Zim/Win32.pm in %prep as, well, we're not on Win32 :) Keeping it around also causes unwanted Win32 requires to be generated. > AND > WARNING: You don't seem to have a mime-info database. > The shared-mime-info package is available from > http://freedesktop.org/wiki/Software_2fshared_2dmime_2dinfo Good catch -- this looks to be a bug with perl-File-MimeInfo not requiring that package. Bug 215972 filed. I'll add an explicit requires on shared-mime-info to Zim in the meantime, and upload new packages. > rpmlint on noarch rpm is not silent > Got rpmlint warning on RPM > W: Zim hidden-file-or-dir /usr/share/zim/doc/.zim.config > The file or directory is hidden. You should see if this is normal, > and delete it from the package if not. This is normal, if a touch odd -- Zim packages its online help as a zim repository. SRPM URL: http://home.comcast.net/~ckweyl/Zim-0.17-2.fc6.src.rpm SPEC URL: http://home.comcast.net/~ckweyl/Zim.spec Review: + package builds in mock (development i386)FC7. + rpmlint is silent for SRPM. + rpmlint on noarch rpm is not silent Got rpmlint warning on RPM W: Zim hidden-file-or-dir /usr/share/zim/doc/.zim.config Which can be ignored. + source files match upstream. b665ab613fc777073e14b5eee44f37d9 Zim-0.17.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. License text included in package. + %doc is small; no -doc subpackage required. + %doc does not affect runtime. + COPYING included in %doc. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc files. + no -devel subpackage exists + no .la files. + no translations available + owns the directories it creates. + doesn't own any directories it shouldn't. + no duplicates in %files. + file permissions are appropriate. + Desktop file installed succesfully + Desktop file is handled correclty in SPEC file. + GUI app APPROVED. COLSE bug once you import this package in CVS Done, thanks! :) Please branch for F-8 :) cvs done. Package Change Request ====================== Package Name: Zim New Branches: el6 Owners: cheeselee InitialCC: cweyl I am the actual maintainer of this package by now, the owner has been inactive with this package for a while. Git done (by process-git-requests). Package Change Request ====================== Package Name: Zim New Branches: epel7 Owners: cheeselee Git done (by process-git-requests). |