Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 216105
Summary: | Review Request: python-twisted-web - Twisted web server, programmable in Python | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Thomas Vander Stichele <thomas> |
Component: | Package Review | Assignee: | Paul Howarth <paul> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | jspaleta, kevin, lkundrak |
Target Milestone: | --- | Flags: | kevin:
fedora-cvs+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-12-28 23:27:58 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779, 171543, 219972, 221310 |
Description
Thomas Vander Stichele
2006-11-17 10:16:31 UTC
Review ====== - package and spec file naming OK - package meets guidelines - license is MIT, matches spec - spec file written in English and is legible - sources match upstream - package builds OK in mock for FC4-Rawhide, i386 and x86_64 - BR's OK - no locale issues - no shared libraries - not relocatable - no directory ownership or permissions issues - %clean section present and correct - macro usage consistent enough - code, not content - docs aren't excessively large - docs don't affect runtime - no subpackages - no devel files present - not a GUI app, no desktop file needed - package seems to work OK (tested with bittorrent 5.0.1) MUSTFIX: * Include LICENSE as %doc PROBLEM: # rpm -qa python-twisted\* python-twisted-web-0.6.0-4.fc6 python-twisted-core-2.4.0-4.fc6 # rpm -e python-twisted-web Traceback (most recent call last): File "/usr/libexec/twisted-dropin-cache", line 16, in ? list(getPlugins(IPlugin)) --- <exception caught here> --- File "/usr/lib64/python2.4/site-packages/twisted/plugin.py", line 214, in getPlugins adapted = interface(plugin, None) File "/usr/lib64/python2.4/site-packages/zope/interface/interface.py", line 658, in __call__ adapter = conform(self) File "/usr/lib64/python2.4/site-packages/twisted/plugin.py", line 77, in __conform__ return self.load() File "/usr/lib64/python2.4/site-packages/twisted/plugin.py", line 72, in load return namedAny(self.dropin.moduleName + '.' + self.name) File "/usr/lib64/python2.4/site-packages/twisted/python/reflect.py", line 370, in namedAny obj = getattr(obj, n) exceptions.AttributeError: 'module' object has no attribute 'twisted_web' I think that needs fixing. NOTES: * rpmlint output: E: python-twisted-web no-binary This is to be expected for what is essentially a noarch package that has to live in an arch-specific place due to the way python works, i.e. not an issue SUGGESTIONS: * URL should be: http://twistedmatrix.com/trac/wiki/TwistedWeb * Include NEWS as %doc Hey Thomas. Any news on the mustfix/suggestion items from this review? thanks to python 2.5 now in the development tree you'll need a new Buildrequires: python-devel You'll find the updated srpm and spec which builds against current fedora-development here: http://jspaleta.thecodergeek.com/Fedora%20SRPMS/python-twisted-web/python-twisted-web-0.6.0-4.src.rpm http://jspaleta.thecodergeek.com/Fedora%20SRPMS/python-twisted-web/python-twisted-web.spec I've also included the LICENSE and NEWS fileas as %doc and updated the URL tag as suggested in the review comment Paul, Kevin, pulled in Jef's updated spec as is. Any further comments, or can this be APPROVEd ? Has anybody else seen the problem with the dropin cache at package removal time that I mentioned in Comment #1? I removed all my packages (including the divmod ones) and now I am able to reproduce it. Before I had it spuriously and couldn't figure out a way to debug it. I dug a little deeper now and it seems that the Twisted code logs an exception using its own log handler when it finds a plugin in the cache that is no longer on disk. Since this is the point of updating the cache - removing plugins that no longer exist - I changed twisted-dropin-cache to not log on that particular error. I pushed a new python-twisted-core package to extras that should fix this. I don't see any more blockers here... using the new python-twisted-core from the buildsys (it's not been pushed yet) I don't see any dropin cache issues. OK, Approved. imported, waiting for fc-6 branch built, closing Thomas: I'm interested in EL-5 branch. Would you maintain it yourself or you won't mind if I maintained it? This is a blocker for my package and the Fedora maintainer seems not to be interested. cvsextras commits will be open and I'm willing aprove the Fedora maintainer once he applies for ACLs. Package Change Request ====================== Package Name: python-twisted-web New Branches: EL-5 Cvsextras Commits: yes cvs done. |