Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 216130 (glest)
| Summary: | Review Request: glest - 3D real time strategy game | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Aurelien Bompard <gauret> |
| Component: | Package Review | Assignee: | Christopher Stone <chris.stone> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | lemenkov, wayward4now |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-11-29 07:43:57 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 210553, 216131 | ||
| Bug Blocks: | 163779 | ||
|
Description
Aurelien Bompard
2006-11-17 13:22:46 UTC
Needs these depends to build: jam is needed by glest-2.0.0-1.i386 openal-devel is needed by glest-2.0.0-1.i386 xerces-c-devel is needed by glest-2.0.0-1.i386 Found the first two easily enough, the xerces-c-devel is harder to find. Ric See bug 210553 (this bug depends on it) ==== REVIEW CHECKLIST ====
- rpmlint output clean
- package named according to package naming guidelines
- spec file name matches %{name}
- package meets packaging guidelines
- licensed with open source compatible license
- license matches actual license
- license file included in %doc
- spec written in American english
- spec legible
- sources match upstream
f7716da7a044dbe108c619b0f52621bb glest_source_2.0.0.zip
- successfully compiles and builds on FC6 x86_64
- all build dependencies listed in BR
- no locales
- no shared libraries
- package is not relocatable
- package owns all directories it creates
- directories it does not create owned by filesystem
- no duplicates in %files
- file permissions set properly
- package contains proper %clean section
- macro usage consistent
- contains code
- no large documentation
- files in %doc do not affect runtime
- no header files or static libraries
- no pkgconfig files
- no need for a devel subpackage
- no .la files
- GUI app contains proper .desktop file
- package does not own files or directories owned by other packages
APPROVED
==== SHOULD ====
- Add punctuation to %description.
Imported and built, thanks for the review ! It plays real choppy on my machine. The audio stutters and the mouse is very slow. I have FC6 installed, 32bit on an Athlon 64 3200+ with two gigs of memory. I have an nVidia 5200 video card with 256megs of memory. Ric Please open a new bug if you want to report a problem, this bug was dedicated to the package review, and is already closed. Thanks |