Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 216282
| Summary: | Review Request: mirage - A fast and simple image viewer | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Mamoru TASAKA <mtasaka> | ||||
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> | ||||
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | michael, sundaram | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2006-11-21 09:20:29 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 163779 | ||||||
| Attachments: |
|
||||||
|
Description
Mamoru TASAKA
2006-11-18 19:00:39 UTC
*** Bug 196570 has been marked as a duplicate of this bug. *** Review: + package builds in mock (development i386) for FC7. + rpmlint is silent for RPM and SRPM. + source files match upstream. c87da5b76f856fd7a759a355259b76ed mirage-0.8.1.tar.bz2 + package meets naming and packaging guidelines. + specfile is properly named and is cleanly written. + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. License text included in package. + %doc is small; no -doc subpackage required. + %doc does not affect runtime. + COPYING included in %doc. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc files. + no -devel subpackage exists + no .la files included. + translations are available. + scriptlets update-desktop-database is used. + owns the directories it creates. + doesn't own any directories it shouldn't. + no duplicates in %files. + file permissions are appropriate. + Desktop file installed successfully + Desktop file is handled correctly in SPEC file. + GUI application + Followed Python packaging guidelines also. APPROVED. Thank you. I will import this to FE when FE CVS system revives. Thanks
I tried building and running the SRPM package and I get the following traceback.
mirage
Traceback (most recent call last):
File "/usr/bin/mirage", line 29, in ?
app = mirage.Base()
File "/usr/lib/python2.4/site-packages/mirage.py", line 270, in __init__
pixbuf = gtk.gdk.pixbuf_new_from_file(leave_fullscreen_icon_path)
gobject.GError: Failed to open file '': No such file or directory
(In reply to comment #5) > I tried building and running the SRPM package and I get the following traceback. I cannot figure out what is the problem only from your information. Currently I can only say 'this program works for me'...... Would you tell me more details so that I can reproduce your situation? By the way, are 3 image files correctly installed under /usr/share/mirage? I used rpmbuild to build the srpm at http://www.ioa.s.u-tokyo.ac.jp/~mtasaka/dist/extras/development/SRPMS/mirage-0.8.1-1.src.rpm. /usr/share/mirage is empty. Is there any additional details you would like to know? Created attachment 141711 [details] rpmbuild build log of mirage-0.8.1-1 by me (In reply to comment #7) > /usr/share/mirage is empty. Is there any additional details you would like to know? This is a problem. Maybe I have to add some BRs (however mockbuild shows no problem for me....) Please attach your build log, which may be helpful. I attach my build log FYI. Rahul, Being the reviewer of this package i had checked all things including build.log and tested application successfully by running it from console and desktop icon also. Its working fine without problem in my machine. Can you submit messages coming from following command at least rpmbuild --rebuild mirage-0.8.1-1.src.rpm ?? Also check that you have pygtk2 and gnome-python2-gconf installed on your system. Remember gnome-python2-gconf is in FC6 Updates and not in FC6 Core repository. Well, * Rebuild for FE-devel succeeded, no problem. http://buildsys.fedoraproject.org/plague-results/fedora-development-extras/mirage/ * SyncNeeded is requested for FE-6, FE-5. Parag, thank you for reviewing and approving this package!! Rahul, if your problem still reappear, please open a new bug report. Now I close this bug as CLOSED NEXTRELEASE. |