Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 216285
Summary: | Review Request: kleansweep - Reclaim disk space by finding unneeded files | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Chitlesh GOORAH <chitlesh> |
Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | ||
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-11-22 20:21:29 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Chitlesh GOORAH
2006-11-18 19:17:31 UTC
When i downloaded and tried to install SRPM i got error: unpacking of archive failed on file /usr/src/redhat/SOURCES/kleansweep-0.2.9.tar.bz2;455ffbc7: cpio: read Ok, looks like it was some download problem. Preliminary review first. Preferred value for buildroot is not present in SPEC value. what do you mean ? %{buildroot} is a blocker ? > %{buildroot} is a blocker ?
To some reviewer, yes. Fortunately, fixing it is easy.
(In reply to comment #4) > > %{buildroot} is a blocker ? > > To some reviewer, yes. Fortunately, fixing it is easy. Ok! Fixed to please Paragn: Spec URL: http://chitlesh.googlepages.com/kleansweep.spec SRPM URL: http://chitlesh.googlepages.com/kleansweep-0.2.9-1.src.rpm However, I would like to document about this, any url ? The preferred value for %buildroot in FE is described at http://fedoraproject.org/wiki/Packaging/Guidelines#head-f196e7b2477c2f5dd97ef64e8eacddfb517f1aa1 Please note that the last link you have provided was probably meant to be http://chitlesh.googlepages.com/kleansweep-0.2.9-2.src.rpm because you did correctly increase the release tag in the spec file and recreate the new src.rpm My bad, I've misunderstood the whole concept. lol Updated: Spec URL: http://chitlesh.googlepages.com/kleansweep.spec SRPM URL: http://chitlesh.googlepages.com/kleansweep-0.2.9-3.src.rpm Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and RPMS. + source files match upstream. eb4530dc77fbe35ede8267e89275e5e9 kleansweep-0.2.9.tar.bz2 + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. License text included in package. + %doc is small; no -doc subpackage required. + %doc does not affect runtime. + COPYING included in %doc. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + .pc file present. + no -devel subpackage exists + Used gtk-update-icon-cache correctly + no .la files. + no translations are available + Dose owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + Desktop file installed succesfully + Desktop file is handled correclty in SPEC file. + GUI app APPROVED. |