Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 216352 (vdr-sudoku)

Summary:	Review Request: vdr-sudoku - Sudoku plugin for VDR
Product:	[Fedora] Fedora	Reporter:	Ville Skyttä <ville.skytta>
Component:	Package Review	Assignee:	Christopher Stone <chris.stone>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-12-03 22:12:37 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779

Description Ville Skyttä 2006-11-19 20:37:35 UTC

http://cachalot.mine.nu/6/SRPMS/vdr-sudoku.spec
http://cachalot.mine.nu/6/SRPMS/vdr-sudoku-0.1.2-0.6.cmn6.src.rpm

This is a VDR plugin to generate and solve number place puzzles, so
called Sudokus.

Comment 1 Christopher Stone 2006-12-03 19:33:43 UTC

==== REVIEW CHECKLIST ====
- rpmlint output clean
- package named according to package naming guidelines
- spec file name matches %{name}
- package meets packaging guidelines
- licensed with open source compatible license
- license matches actual license
- license included in %doc
- spec written in American english
- spec legible
- source match upstream
a32cc677477349823469542896ad389d  vdr-sudoku-0.1.2.tgz
- successfully compiles and builds on FC6 x86_64
- all build dependencies listed in BR
- no locales
- no shared libraries
- not relocatable
- package owns all directories it creates
- directories it does not own are owned by Requires packages
- no duplicates in %files
- file permissions set properly
- contains proper %clean
- macro usage is consistent
- contains code
- no large documentation
- %doc does not affect runtime
- no header files or static libraries
- no pkgconfig files
- devel subpackage not required
- no .la files
- not a GUI application needing a .desktop file
- does not own files or directories owned by other packages

APPROVED

Comment 2 Ville Skyttä 2006-12-03 22:12:37 UTC

Thanks!

22892 (vdr-sudoku): Build on target fedora-development-extras succeeded.
owners.list updated, FC-6 branch requested, comps updates forthcoming.