Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 216755
Summary: | Review Request: GLiv - OpenGL image viewer | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Peter Lemenkov <lemenkov> | ||||
Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> | ||||
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> | ||||
Severity: | medium | Docs Contact: | |||||
Priority: | medium | ||||||
Version: | rawhide | CC: | adrien-xx-redhatbz, ajax, lersek, mtasaka | ||||
Target Milestone: | --- | ||||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2006-11-22 19:15:18 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | |||||||
Bug Blocks: | 163779 | ||||||
Attachments: |
|
Description
Peter Lemenkov
2006-11-21 20:54:10 UTC
*** Bug 193446 has been marked as a duplicate of this bug. *** Created attachment 141851 [details]
Mock build log of gliv 1.9.5-2.fc7
mockbuild on FC-devel i386 fails.
Please check the build log.
(In reply to comment #2) > Created an attachment (id=141851) [edit] > Mock build log of gliv 1.9.5-2.fc7 > > mockbuild on FC-devel i386 fails. > Please check the build log. Added missing BR. Updated to 1.9.6 http://lemenkov.newmail.ru/SPECS/gliv.spec http://lemenkov.newmail.ru/SRPMS/gliv-1.9.6-1.src.rpm Well; 1. From http://fedoraproject.org/wiki/Packaging/Guidelines : * Use rpmlint - Rpmlint is not silent. ----------------------------------------------------------- //usr/share/applications/fedora-gliv.desktop: warning: Categories values must be one of <snip> (found "Application") //usr/share/applications/fedora-gliv.desktop: warning: Categories values must be one of <snip> (found "X-Red-Hat-Base") ----------------------------------------------------------- The category 'Application' and 'X-Red-Hat-Base' is no longer used (since desktop-file-utils 0.11) and this should be removed. NOTE: These warnings can be seem only in FC-devel. * Documentation ------------------------------- %doc %{_mandir}/man1/gliv.1* %doc %{_mandir}/*/man1/gliv.1* ------------------------------ - man manual files should not be marked as %doc. * Why the %makeinstall macro should not be used - Don't use %makeinstall macro as this is known to be broken. * Scriptlets requirements: Please check http://fedoraproject.org/wiki/Packaging/ScriptletSnippets * desktop-database - fedora-gliv.desktop has MimeType and this requires 'update-desktop-database'. 2. From http://fedoraproject.org/wiki/Packaging/ReviewGuidelines : * The sources .... as provided in the spec URL -------------------------------------------- [tasaka1@localhost gliv]$ LANG=C wget -N http://guichaz.free.fr/gliv/gliv-1.9.6.tar.bz2 --23:19:24-- http://guichaz.free.fr/gliv/gliv-1.9.6.tar.bz2 Resolving guichaz.free.fr... 212.27.63.100 Connecting to guichaz.free.fr|212.27.63.100|:80... connected. HTTP request sent, awaiting response... 404 Not Found 23:19:25 ERROR 404: Not Found. -------------------------------------------- (In reply to comment #4) > Well; > > 1. From http://fedoraproject.org/wiki/Packaging/Guidelines : > * Use rpmlint > - Rpmlint is not silent. Fixed. > * Documentation > ------------------------------- > %doc %{_mandir}/man1/gliv.1* > %doc %{_mandir}/*/man1/gliv.1* > ------------------------------ > - man manual files should not be marked as %doc. Done. > * Why the %makeinstall macro should not be used > - Don't use %makeinstall macro as this is known to be broken. Fixed. > 2. From http://fedoraproject.org/wiki/Packaging/ReviewGuidelines : > * The sources .... as provided in the spec URL Fixed. (In reply to comment #4) > ----------------------------------------------------------- > //usr/share/applications/fedora-gliv.desktop: warning: > Categories values must be one of <snip> > (found "Application") > > //usr/share/applications/fedora-gliv.desktop: warning: > Categories values must be one of <snip> > > (found "X-Red-Hat-Base") > ----------------------------------------------------------- > The category 'Application' and 'X-Red-Hat-Base' is no > longer used (since desktop-file-utils 0.11) and this > should be removed. > > NOTE: These warnings can be seem only in FC-devel. Which cateories should I use in this case? > * Scriptlets requirements: > Please check > http://fedoraproject.org/wiki/Packaging/ScriptletSnippets > * desktop-database > - fedora-gliv.desktop has MimeType and this requires > 'update-desktop-database'. Done. (In reply to comment #6) > (In reply to comment #4) > > > The category 'Application' and 'X-Red-Hat-Base' is no > > longer used (since desktop-file-utils 0.11) and this > > should be removed. > > > > NOTE: These warnings can be seem only in FC-devel. > > > Which cateories should I use in this case? Categories should be: ---------------------------------------- Categories=GNOME;Graphics; ---------------------------------------- I forgot one more comment. --------------------------------------- Icon=redhat-graphics.png --------------------------------------- This is incorrect because redhat-graphics.png is not installed by this package. (In reply to comment #7) > > Which cateories should I use in this case? > > Categories should be: > ---------------------------------------- > Categories=GNOME;Graphics; > ---------------------------------------- OK. > I forgot one more comment. > --------------------------------------- > Icon=redhat-graphics.png > --------------------------------------- > This is incorrect because redhat-graphics.png is not installed > by this package. I changed it to: Icon=gliv.png Unfortunately (Fortunately!) I don't use pretty-looking modern software such as Gnome or KDE, so I can't check all that desktop stuff ) ver. 1.9.6-2 http://lemenkov.newmail.ru/SPECS/gliv.spec http://lemenkov.newmail.ru/SRPMS/gliv-1.9.6-1.src.rpm Okay. --------------------------------------------- This package (gliv) is APPROVED by me. Thanks. Successfully built in FE-Devel Package Change Request ====================== Package Name: gliv New Branches: el6 Owners: ajax Justification: builds out of the box (http://koji.fedoraproject.org/koji/taskinfo?taskID=3598153), small, light, useful; less intrusive and more handy than gthumb for example, especially when zooming and rotating. Here's a comparison between the (install) deps: Need by both: /bin/sh libX11.so.6()(64bit) libc.so.6()(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.3)(64bit) libc.so.6(GLIBC_2.3.4)(64bit) libc.so.6(GLIBC_2.4)(64bit) libcairo.so.2()(64bit) libgdk-x11-2.0.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgthread-2.0.so.0()(64bit) libgtk-x11-2.0.so.0()(64bit) libm.so.6()(64bit) libm.so.6(GLIBC_2.2.5)(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpthread.so.0()(64bit) libpthread.so.0(GLIBC_2.2.5)(64bit) rpmlib(CompressedFileNames) <= 3.0.4-1 <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 <= 4.0-1 rpmlib(PayloadIsXz) <= 5.2-1 <= 5.2-1 rtld(GNU_HASH) Needed by gthumb only: /bin/bash GConf2 >= 2.14 desktop-file-utils >= 0.9 libORBit-2.so.0()(64bit) libXrender.so.1()(64bit) libart_lgpl_2.so.2()(64bit) libbonobo-2.so.0()(64bit) libbonobo-activation.so.4()(64bit) libc.so.6(GLIBC_2.11)(64bit) libc.so.6(GLIBC_2.7)(64bit) libexif.so.12()(64bit) libgconf-2.so.4()(64bit) libglade-2.0.so.0()(64bit) libgnome-2.so.0()(64bit) libgnomecanvas-2.so.0()(64bit) libgnomeui-2.so.0()(64bit) libgnomevfs-2.so.0()(64bit) libgphoto2.so.2()(64bit) libgphoto2_port.so.0()(64bit) libgthumb.so()(64bit) libiptcdata.so.0()(64bit) libjpeg.so.62()(64bit) libopenrawgnome.so.1()(64bit) libpng12.so.0()(64bit) libpng12.so.0(PNG12_0)(64bit) libtiff.so.3()(64bit) libxml2.so.2()(64bit) libxml2.so.2(LIBXML2_2.4.30)(64bit) scrollkeeper Needed by gliv only: libGL.so.1()(64bit) libGLU.so.1()(64bit) libICE.so.6()(64bit) libSM.so.6()(64bit) libXmu.so.6()(64bit) libXt.so.6()(64bit) libatk-1.0.so.0()(64bit) libfontconfig.so.1()(64bit) libfreetype.so.6()(64bit) libgdkglext-x11-1.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libgtkglext-x11-1.0.so.0()(64bit) libpangoft2-1.0.so.0()(64bit) libpangox-1.0.so.0()(64bit) librt.so.1()(64bit) |