Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 216947
| Summary: | Review Request: perl-Gtk2-Notify - Gtk2::Notify Perl module | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Chris Weyl <cweyl> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | ||
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://search.cpan.org/dist/Gtk2-Notify/ | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-11-27 18:52:00 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779 | ||
|
Description
Chris Weyl
2006-11-22 20:20:21 UTC
Tests now conditionalized -- they tend to die horribly under mock due to the lack of $DISPLAY. SRPM URL: http://home.comcast.net/~ckweyl/perl-Gtk2-Notify-0.02-2.fc6.src.rpm SPEC URL: http://home.comcast.net/~ckweyl/perl-Gtk2-Notify.spec I just had a look for Source URL and found given source download link is not working. Ok, that's weird. It is working from the by-authors perspective; I'll update the spec to use this one. http://search.cpan.org/CPAN/authors/id/F/FL/FLORA/Gtk2-Notify-0.02.tar.gz Till you take time to update new SRPM here comes review Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and but NOT for RPMS. But those warnings are ignored. + source files match upstream. 77a64c944cf1516bcc514456de22a82b Gtk2-Notify-0.02.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. License text included in package. + %doc is small; no -doc subpackage required. + %doc does not affect runtime. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + .pc file present. + no -devel subpackage exists + no .la files. + no translations are available + Dose owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + Followed perl packaging guidelines. APPROVED. I checked md5 against Source URL you provided. I can approve this package if you are going to include new source url while importing this package or submit new one . Will check it and then actually approve this package. Updated with new source url: SRPM URL: http://home.comcast.net/~ckweyl/perl-Gtk2-Notify-0.02-3.fc6.src.rpm SPEC URL: http://home.comcast.net/~ckweyl/perl-Gtk2-Notify.spec You forget to add version in Changelog entry. rpmlint is complaining for it now. Fixed. SPEC URL: http://home.comcast.net/~ckweyl/perl-Gtk2-Notify.spec Thanks Imported into cvs, branches requested, and building for devel. Thanks for the review! :) |