Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 217239 (arrows)
Summary: | Review Request: arrows - Neat little maze game | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Hans de Goede <hdegoede> |
Component: | Package Review | Assignee: | Christopher Stone <chris.stone> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | ||
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-11-25 21:17:24 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Hans de Goede
2006-11-25 15:38:54 UTC
==== REVIEW CHECKLIST ==== - rpmlint output clean - package named according to package naming guidelines - spec filename matches %{name} - package meets Packaging Guidelines - package licensed with open source compatible license - license matches actual license - license file included in %doc - spec written in American english - spec is legible - sources match upstream d6cf52ff319c295b9fb6982c023ec7f0 arrows-0.6.tar.gz - successfully compiles and builds on FC6 x86_64 - all build dependencies listed in BR - no locales - no shared libraries - package is not relocatable - package owns all directories it creates X package uses a directory it doesnt create and I cannot determine if its pulled in from Requires packages. This package puts an icon in /usr/share/icons/hicolor/24x24/apps/ - no duplicates in %files - file permissions set properly - package contains proper %clean - macro usage consistent - contains code - no large documentation - %doc does not affect runtime - no header files or static libraries - no pkgconfig files - no devel subpackage required - no .la files O desktop file installed properly (although see my comment in SHOULD fix) - package does not own files or directories owned by other packages ==== MUST FIX ==== - Shouldn't this require some package to get the icon dir? If not, please tell me how I determine which Requires would pull this in. Perhaps Require: gnome-icon-theme? Or hicolor-icon-theme if you decide to move this out of the GNOME menu (see SHOULD FIX section). ==== SHOULD FIX ==== - I'm not sure I agree all games compiled with gtk2 should be placed under GNOME->Games. I think GNOME->Games should be for games that are distributed with GNOME much like KDE has their kde-games package. This may require further discussion on the fedora-games-list. Not a blocker. (In reply to comment #1) > ==== MUST FIX ==== > - Shouldn't this require some package to get the icon dir? If not, please tell > me how I determine which Requires would pull this in. Perhaps Require: > gnome-icon-theme? Or hicolor-icon-theme if you decide to move this out of the > GNOME menu (see SHOULD FIX section). > Yes it should have a "Requires: hicolor-icon-theme", my bad , fixed. > ==== SHOULD FIX ==== > - I'm not sure I agree all games compiled with gtk2 should be placed under > GNOME->Games. I think GNOME->Games should be for games that are distributed > with GNOME much like KDE has their kde-games package. This may require further > discussion on the fedora-games-list. Not a blocker. I took that GNOME entry in the .desktop over from the package on which I based mine, but I agree it isn't a gnome app, dropped. New version here: Spec URL: http://people.atrpms.net/~hdegoede/arrows.spec SRPM URL: http://people.atrpms.net/~hdegoede/arrows-0.6-2.fc7.src.rpm All MUST/SHOULD items fixed. Please re-check scummvm spec for icon issue mentioned here, I might have missed this on my review of scummvm. APPROVED. Thanks, imported and build, closing. p.s. scummvm is fine. |