Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 217278

Summary:	Review Request: tcd-utils - TCD (Tide Constituent Database) Utils
Product:	[Fedora] Fedora	Reporter:	Mamoru TASAKA <mtasaka>
Component:	Package Review	Assignee:	Patrice Dumas <pertusus>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	dave, pertusus
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-11-26 15:34:35 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	217277
Bug Blocks:	163779

Description Mamoru TASAKA 2006-11-26 12:25:20 UTC

Spec URL: http://www.ioa.s.u-tokyo.ac.jp/~mtasaka/dist/packages/xtide/SPECS/tcd-utils.spec
SRPM URL: http://www.ioa.s.u-tokyo.ac.jp/~mtasaka/dist/packages/xtide/SRPMS/
Description: 
TCD Utils includes:
* build_tide_db to convert harmonics.txt, offsets.xml, and NAVO
  formats to harmonics.tcd;
* restore_tide_db to generate harmonics.txt and offsets.xml from
  harmonics.tcd

Comment 1 Mamoru TASAKA 2006-11-26 12:28:17 UTC

srpm is:
http://www.ioa.s.u-tokyo.ac.jp/~mtasaka/dist/packages/xtide/SRPMS/tcd-utils-20061120-1.fc7.src.rpm

Comment 2 Patrice Dumas 2006-11-26 13:09:14 UTC

* right name
* license right, COPYING included
* source match upstream
f0d58145520be7eeaf5d78229dae4aa7  tcd-utils-20061120.tar.bz2
* %files right
* rpmlint is silent

APPROVED

Comment 3 Paul F. Johnson 2006-11-26 13:48:36 UTC

If the mkdir under install required? make install should do this automatically.
I take it that this built fine in mock as well.

Comment 4 Mamoru TASAKA 2006-11-26 15:34:35 UTC

* Rebuild for FE-devel succeeded.
* SyncNeeded is requested for FE5/6.

Now I close this bug as CLOSED NEXTRELEASE. Thank you.

(In reply to comment #3)
> If the mkdir under install required? make install should do this automatically.
> I take it that this built fine in mock as well.
> 
It may be unneeded, however, this is my habit...

Comment 5 Patrice Dumas 2006-11-26 20:13:18 UTC

(In reply to comment #4)

> It may be unneeded, however, this is my habit...

If it is unneeded, it is better to leave it out, since less
code means better readability and maintainability, and your 
specs may be used by others as template. Not a blocker, though.

Comment 6 Mamoru TASAKA 2006-11-27 08:24:11 UTC

(In reply to comment #5)
> If it is unneeded, it is better to leave it out, since less
> code means better readability and maintainability, and your 
> specs may be used by others as template. Not a blocker, though.

As newer version (20061127) is released, I will check this
version and remove 'mkdir /var/tmp/...' if it is possible (perhaps
possible). Thank you, Patrice and Paul.

Comment 7 Patrice Dumas 2006-11-27 10:55:16 UTC

I sent David a patch about setting CPPFLAGS instead of CXXFLAGS
for tideEditor, and he also made that a similar change in tcd-utils.
This should remove a warning in configure.