Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 217484

Summary: Review Request: rlwrap - Wrapper for GNU readline
Product: [Fedora] Fedora Reporter: Michel Alexandre Salim <michel.salim>
Component: Package ReviewAssignee: Parag AN(पराग) <panemade>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Package Reviews List <fedora-package-review>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: michel
Target Milestone: ---Flags: michel: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2006-11-29 15:06:59 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 163779    

Description Michel Alexandre Salim 2006-11-28 05:41:00 UTC
Spec URL: http://hircus.org/fedora/rlwrap/rlwrap.spec
SRPM URL: http://hircus.org/fedora/rlwrap/rlwrap-0.28-1.src.rpm
Description:

rlwrap is a 'readline wrapper' that uses the GNU readline library to
allow the editing of keyboard input for any other command. Input
history is remembered across invocations, separately for each command;
history completion and search work as in bash and completion word
lists can be specified on the command line.

Comment 1 Parag AN(पराग) 2006-11-28 06:11:54 UTC
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and RPMS.
+ source files match upstream.
057871cb04d9dec237ac565aff5a93d7  rlwrap-0.28.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.  License text included in package.
+ %doc is small; no -doc subpackage required.
+ %doc does not affect runtime.
+ COPYING included in %doc.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel or any subpackages exists
+ no .la files.
+ no translations are available
+ Dose owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
APPROVED.


Comment 2 Michel Alexandre Salim 2006-11-29 15:06:59 UTC
Built in Rawhide. Requesting stable branches now. Thanks!

Comment 3 Michel Alexandre Salim 2007-09-12 03:03:47 UTC
Package Change Request
======================
Package Name: rlwrap
New Branches: EL-4 EL-5


Comment 4 Kevin Fenzi 2007-09-12 17:48:35 UTC
cvs done.

Comment 5 Michel Alexandre Salim 2014-05-23 03:19:37 UTC
Package Change Request
======================
Package Name: rlwrap
New Branches: epel7
Owners: salimma

Comment 6 Gwyn Ciesla 2014-05-27 12:38:23 UTC
Git done (by process-git-requests).