Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 2181282

Summary:	apron: Use _fortify_level to manage fortification
Product:	[Fedora] Fedora	Reporter:	Siddhesh Poyarekar <sipoyare>
Component:	apron	Assignee:	Jerry James <loganjerry>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	38	CC:	dmalcolm, loganjerry
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	apron-0.9.13-17.fc38	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-04-01 00:16:16 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2158232

Description Siddhesh Poyarekar 2023-03-23 14:49:08 UTC

It looks like apron tries to drop _FORTIFY_SOURCE from Makefile.config using a regex:

sed -i 's/-Wp,-D_FORTIFY_SOURCE=2/-Werror=format-security &/' Makefile.config

This no longer works and apron now gets built with _FORTIFY_SOURCE=3. Is disabling fortification necessary?  If yes, then please using the new %_fortify_level macro instead:

https://src.fedoraproject.org/rpms/redhat-rpm-config/blob/rawhide/f/buildflags.md

Comment 1 Jerry James 2023-03-23 15:24:53 UTC

No, it isn't removing the fortify flag.  Notice the '&' character on the right hand side.  It's using the fortify flag to find a place to reinsert -Werror=format-security, which upstream's configure script removes.  I'll find a different anchor for reinserting that flag, or else bludgeon the configure script into not removing it in the first place.

Thanks for bringing this to my attention.

Comment 2 Fedora Update System 2023-03-23 16:32:49 UTC

FEDORA-2023-c3f47099c2 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-c3f47099c2

Comment 3 Fedora Update System 2023-03-24 03:01:13 UTC

FEDORA-2023-c3f47099c2 has been pushed to the Fedora 38 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-c3f47099c2

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 4 Fedora Update System 2023-04-01 00:16:16 UTC

FEDORA-2023-c3f47099c2 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.