Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 218229 (pear-Image-Color)
| Summary: | Review Request: php-pear-Image-Color - Manage and handles color data and conversions | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Christopher Stone <chris.stone> |
| Component: | Package Review | Assignee: | Remi Collet <fedora> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | Flags: | wtogami:
fedora-cvs+
|
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-12-07 20:00:02 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779 | ||
|
Description
Christopher Stone
2006-12-03 22:16:04 UTC
This package is used by php-pear-Image-Canvas in which tests works (so this
package works).
REVIEW
* source files match upstream:
a4a1a6f5c0f72d235930902cc1ee2e94 /tmp/Image_Color-1.0.2.tgz
a4a1a6f5c0f72d235930902cc1ee2e94 SOURCES/Image_Color-1.0.2.tgz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible (PHP).
* latest version is being packaged (1.0.2)
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development).
* package installs properly
* rpmlint is silent.
* final provides are sane:
php-pear(Image_Color) = 1.0.2
php-pear-Image-Color = 1.0.2-1.fc7
* %check is not present; no test suite provide.
* owns the directories it creates (see comment)
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets are OK (pear install)
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
Should : remplace in %file
%{pear_phpdir}/*
by
%{pear_phpdir}/Image
More explicit and allow detection of new directory in next release (testdir p.e.)
APPROVED
Added Image dir. Built successfully on devel. Requested CVS sync with FC5/6. Added entry to owners.list. Thanks for the review. Package Change Request ====================== Package Name: php-pear-Image-Color New Branches: EL-5 |