Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 218600
Summary: | Review Request: resapplet - Resolution Switching Applet | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Radek Vokál <rvokal> |
Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | ||
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-12-22 21:53:57 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Radek Vokál
2006-12-06 13:00:04 UTC
Preliminary review reveals that rpmlint is not silent on RPM W: resapplet no-version-in-last-changelog The last changelog entry doesn't contain a version. Please insert the version that is coherent with the version of the package and rebuild it. ==>Add Changelog as * Wed Dec 6 2006 Radek Vokál <rvokal> - 0.1.1-1 W: resapplet no-url-tag The URL tag is missing. ==> As no upstream so no URL is appearing here. /tmp/resapplet-0.1.1-1.i386.rpm.7539/usr/share/applications/resapplet.desktop: error: required key "Encoding" not found E: resapplet invalid-desktopfile /tmp/resapplet-0.1.1-1.i386.rpm.7539/usr/share/applications/resapplet.desktop .desktop file is not valid, check with desktop-file-validate ==> You need to add following line to your desktop file Encoding=UTF-8 SHOULD: buildroot must be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) http://people.redhat.com/rvokal/resapplet/resapplet.spec http://people.redhat.com/rvokal/resapplet/resapplet-0.1.1-2.src.rpm Buildroot, Changelog and Encoding fixed. Still needs some Fixes rpmlint on SRPM reports W: resapplet mixed-use-of-spaces-and-tabs (spaces: line 51, tab: line 1) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both. Also you need to install Desktop files as given below http://fedoraproject.org/wiki/Packaging/Guidelines#head-254ddf07aae20a23ced8cecc219d8f73926e9755 Change SPEC file. http://people.redhat.com/rvokal/resapplet/resapplet.spec http://people.redhat.com/rvokal/resapplet/resapplet-0.1.1-3.src.rpm Changed location of desktop file, added Buildrequires desktop-file-utils, cleaned tabs and spaces. forgot to mention you need to add scriptlets also. http://fedoraproject.org/wiki/Packaging/ScriptletSnippets?highlight=%28scriptlets%29#head-7103f6c38d1b5735e8477bdd569ad73ea2c49bda Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and RPMS. + source files md5sum. No upstream is available. 0f1d30b02182ff1ec463b3bc37e9326c resapplet-0.1.1.tar.bz2 + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. License text included in package. + %doc is small; no -doc subpackage required. + %doc does not affect runtime. + COPYING included in %doc. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel or any subpackages exists + no .la files. + translations are available + Dose owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + Desktop files are handled in usual way. - Not Used gtk-update-icon-cache scriptlet Add scriptlet update package. Cool applet tested successfully on FC6 i386 system. oops rpmlint is NOT silent but taking it as silent as only remaining warning is of no-url-tag and which can be considerable as there is no upstream (here i am aussming that packages in Fedora Core are existing without URL tag, so does can be allowed in FE) Got one reference for no-url-tag (bug 200422) where Tim put tarball on somw web space. Can you also do that? I think you can use people.redhat.com also. So Update url tag in SPEC also. I don't think a empty URL tag is a problem. I'd say put a comment before the Source0 line in the spec that points to the srpms from Opensuse where you obtained the sources. I'm still not sure about the correct placement of pixmap files. Can you please review the spec file and help me with it. The place should be consistent but now there are two directories where icons are stored. I've updated the spec file with the scripplet (just for one location) and comment above the Source0. Try patching Makefiles in icons directory to install icons in path $RPM_BUILD_ROOT%{_datadir}/pixmaps/hicolor instead default installation to $(datadir)/icons/gnome/16x16/apps in Makefiles.am Then no need of icons scriptlets remains. I mean change $(datadir)/icons/gnome/16x16/apps to $(datadir)/pixmaps/hicolor/16x16/apps I have decided to remove all Suse icons and keep only the original ones. Please check my latest changes http://people.redhat.com/rvokal/resapplet/resapplet.spec http://people.redhat.com/rvokal/resapplet/resapplet-0.1.1-4.src.rpm Thanks. rpmlint is reporting only no-url-tag warning. Everthign other looks OK. APPROVED. Don't Forget to CLOSE this review request once you import and build package in CVS. I won't. Just didn't have time to import it yet. I'll do it today. take your time. I just reminded you :) hmm, I haven't touched extras for some time and now I get this radek@localhost CVS$ export CVSROOT=:ext:rvokal.redhat.com:/cvs/extras radek@localhost CVS$ export CVS_RSH=ssh radek@localhost CVS$ cvs co common Permission denied (publickey,keyboard-interactive). cvs [checkout aborted]: end of file from server (consult above messages if any) and I tried to upload new ssh publickey but still I'm seeing this. What should be wrong? Have you checked whether your ssl cert has expired? Also, I noticed that the owners.list file lists resapplet as belonging to rvokal. If this is just a typo, please change it to rvokal. I fixed that by uploading a new ssh key. Thanks |