Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 218721
| Summary: | Review Request: perl-Test-Distribution - Perform tests on all modules of a distribution | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Chris Weyl <cweyl> |
| Component: | Package Review | Assignee: | Jason Tibbitts <j> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | kevin, paul, pertusus |
| Target Milestone: | --- | Flags: | dennis:
fedora-cvs+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://search.cpan.org/dist/Test-Distribution/ | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-12-07 02:43:38 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779, 218722 | ||
|
Description
Chris Weyl
2006-12-07 00:05:52 UTC
* source files match upstream: 64dc13f51f60f6022bb8e628f1297957 Test-Distribution-1.26.tar.gz * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible. License text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * rpmlint is silent. * final provides and requires are sane: perl(Test::Distribution) = 1.26 perl(Test::Distribution::base) perl(Test::Distribution::description) perl(Test::Distribution::exports) perl(Test::Distribution::manifest) perl(Test::Distribution::pod) perl(Test::Distribution::podcover) perl(Test::Distribution::prereq) perl(Test::Distribution::sig) perl(Test::Distribution::use) perl(Test::Distribution::versions) perl-Test-Distribution = 1.26-1.fc7 = perl(:MODULE_COMPAT_5.8.8) perl(ExtUtils::Manifest) perl(File::Find::Rule) >= 0.03 perl(Module::CoreList) >= 1.93 perl(Module::Signature) perl(Pod::Coverage) >= 0.17 perl(Test::More) perl(Test::Pod) >= 0.95 perl(Test::Pod::Coverage) perl(strict) perl(vars) perl(warnings) * %check is present and all tests pass: All tests successful, 6 subtests skipped. Files=9, Tests=46, 2 wallclock secs ( 0.89 cusr + 0.24 csys = 1.13 CPU) The skipped checks are due to either gpg failures due to missing keys (would probably require network access) or due to unimplemented tests. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. APPROVED Imported and building for devel; branches requested for FC-[56]. Thanks for the review! Package Change Request ====================== Package Name: perl-Test-Distribution New Branches: EL-4 EL-5 Updated EPEL Owners: pertusus cweyl Chris accepted my offer to be EPEL maintainer by mail, maybe he should confirm? Sure, Chris? Sorry for the delay -- with pleasure, confirmed :) cvs done. Package Change Request ====================== Package Name: perl-Test-Distribution New Branches: EL-6 Updated EPEL Owners: pghmcfc cweyl this was excluded from mass branching of EL-6 why is it being added now ? The EPEL-4/5 maintainer (pertusus) isn't maintaining packages in EPEL-6 (and will probably orphan EPEL-4/5 if someone else will pick it up - I will be happy to do that by the way); I didn't realise I needed this package as a dependency of one of my modules so I didn't take this package when Patrice offered his packages prior to the mass branching. OK CVS Done |