Bug 2189420

*** Bug 2049808 has been marked as a duplicate of this bug. ***

Copr build:
https://copr.fedorainfracloud.org/coprs/build/5847629
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2189420-awscli2/fedora-rawhide-x86_64/05847629-awscli2/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Taking this review.

> Provides:           awscli = %{version}-%{release}
> Obsoletes:          awscli < 2

Are we getting rid of awscli v1?

> Taking this review.

Thanks.

> Are we getting rid of awscli v1?

In Fedora, yes, eventually, but not in EPEL, see bug #2049808 comment 2.

We've shipped `awscli-2` in Amazon Linux 2023, it'd be great if there was a path forward without us having to patch the SPEC, perhaps a Provides?

Ok, I've added a provide.

Spec URL: https://download.copr.fedorainfracloud.org/results/nforro/awscli2/fedora-rawhide-x86_64/05851145-awscli2/awscli2.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/nforro/awscli2/fedora-rawhide-x86_64/05851145-awscli2/awscli2-2.11.15-1.fc39.src.rpm

Created attachment 1960074 [details]
The .spec file difference from Copr build 5847629 to 5851296

Copr build:
https://copr.fedorainfracloud.org/coprs/build/5851296
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2189420-awscli2/fedora-rawhide-x86_64/05851296-awscli2/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

> # provide an upgrade path from awscli-2 (Amazon Linux)
> Provides:           awscli-2 = %{version}-%{release}

Obsoletes is needed here too, otherwise it's not an upgrade path.

> Obsoletes is needed here too, otherwise it's not an upgrade path.

Hm, can I use dynamic version here?

Obsoletes:  awscli-2 < %{version}-%{release}

(In reply to Nikola Forró from comment #11)
> > Obsoletes is needed here too, otherwise it's not an upgrade path.
> 
> Hm, can I use dynamic version here?
> 
> Obsoletes:  awscli-2 < %{version}-%{release}

Yes, that's fine. :)

Spec URL: https://download.copr.fedorainfracloud.org/results/nforro/awscli2/fedora-rawhide-x86_64/05852030-awscli2/awscli2.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/nforro/awscli2/fedora-rawhide-x86_64/05852030-awscli2/awscli2-2.11.15-1.fc39.src.rpm

Created attachment 1960150 [details]
The .spec file difference from Copr build 5851296 to 5852118

Copr build:
https://copr.fedorainfracloud.org/coprs/build/5852118
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2189420-awscli2/fedora-rawhide-x86_64/05852118-awscli2/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

just adding my 2-cents to the move. This looks great and works with the new method that the upstream project put together. We would have needed a new review. If you would like a co-maintainer, I am happy to assist.

Updated to 2.11.16.

Spec URL: https://download.copr.fedorainfracloud.org/results/nforro/awscli2/fedora-rawhide-x86_64/05866472-awscli2/awscli2.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/nforro/awscli2/fedora-rawhide-x86_64/05866472-awscli2/awscli2-2.11.16-1.fc39.src.rpm

Created attachment 1961619 [details]
The .spec file difference from Copr build 5852118 to 5866524

Copr build:
https://copr.fedorainfracloud.org/coprs/build/5866524
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2189420-awscli2/fedora-rawhide-x86_64/05866524-awscli2/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

A couple of things here:

> BuildRequires:      python%{python3_pkgversion}-mock

This package is deprecated and this needs to be migrated to unittest.mock: https://fedoraproject.org/wiki/Changes/DeprecatePythonMock

There's also a lot of duplicate files, which can be cleaned up with %fdupes by adding "BuildRequires: fdupes" and "%fdupes -s %{buildroot}%{python3_sitelib}" at the end of %install.

Thanks, let me take care of that.

> There's also a lot of duplicate files, which can be cleaned up with %fdupes
> by adding "BuildRequires: fdupes" and "%fdupes -s
> %{buildroot}%{python3_sitelib}" at the end of %install.

This one will be a little tricky, doing this breaks some imports.

(In reply to Nikola Forró from comment #21)
> Thanks, let me take care of that.
> 
> > There's also a lot of duplicate files, which can be cleaned up with %fdupes
> > by adding "BuildRequires: fdupes" and "%fdupes -s
> > %{buildroot}%{python3_sitelib}" at the end of %install.
> 
> This one will be a little tricky, doing this breaks some imports.

Then don't worry about this.

Removed python3-mock:

Spec URL: https://download.copr.fedorainfracloud.org/results/nforro/awscli2/fedora-rawhide-x86_64/05870070-awscli2/awscli2.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/nforro/awscli2/fedora-rawhide-x86_64/05870070-awscli2/awscli2-2.11.16-1.fc39.src.rpm


> This one will be a little tricky, doing this breaks some imports.

This happens because %fdupes -s replaces duplicate files with absolute symlinks that are invalid (don't point to buildroot) during %check.

Created attachment 1961974 [details]
The .spec file difference from Copr build 5866524 to 5870259

Copr build:
https://copr.fedorainfracloud.org/coprs/build/5870259
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2189420-awscli2/fedora-rawhide-x86_64/05870259-awscli2/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

I forgot to remove the fdupes build requirement.

Spec URL: https://download.copr.fedorainfracloud.org/results/nforro/awscli2/fedora-rawhide-x86_64/05870681-awscli2/awscli2.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/nforro/awscli2/fedora-rawhide-x86_64/05870681-awscli2/awscli2-2.11.16-1.fc39.src.rpm

Created attachment 1962118 [details]
The .spec file difference from Copr build 5870259 to 5872293

Copr build:
https://copr.fedorainfracloud.org/coprs/build/5872293
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2189420-awscli2/fedora-rawhide-x86_64/05872293-awscli2/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

The remaining issue is that the license files aren't captured in the file list using %license.

Thanks, I missed that as it's usually handled by %pyproject_save_files, but I guess it doesn't work with flit-core build backend.

Spec URL: https://download.copr.fedorainfracloud.org/results/nforro/awscli2/fedora-rawhide-x86_64/05872685-awscli2/awscli2.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/nforro/awscli2/fedora-rawhide-x86_64/05872685-awscli2/awscli2-2.11.16-1.fc39.src.rpm

Created attachment 1962188 [details]
The .spec file difference from Copr build 5872293 to 5872722

Copr build:
https://copr.fedorainfracloud.org/coprs/build/5872722
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2189420-awscli2/fedora-rawhide-x86_64/05872722-awscli2/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Review notes:

* Package is named per packaging guidelines
* Package licensing is accurate and license data is captured
* Package builds and installs
* No serious issues from rpmlint

PACKAGE APPROVED.

Thanks!

The Pagure repository was created at https://src.fedoraproject.org/rpms/awscli2

FEDORA-2023-dc0b65d976 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-dc0b65d976

FEDORA-2023-88a95f3a92 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-88a95f3a92

FEDORA-2023-88a95f3a92 has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-88a95f3a92 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-88a95f3a92

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2023-dc0b65d976 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-dc0b65d976 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-dc0b65d976

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

What options are there to get this package available somewhere to install for RHEL8?

I understand EPEL already has the `awscli` version 1 package, but we already use the improvements made to awscli version 2.

Our only option up until I saw this package available was automating the downloading and check of the official zip file.

It would be of great help to make a RHEL package available.

I don't think that's realistic, EL 8 doesn't support pyproject macros, so almost the entire spec file would have to be rewritten, not to mention outdated dependencies.

It seems that you are missing bunch of Provides: bundled(…)

Ops, I will add:

Provides:  bundled(python3dist(botocore)) = 2.0.0
Provides:  bundled(python3dist(s3transfer)) = 0.5.1

I hope I didn't miss something else. Also, let me see if I can try unbundling s3transfer.

FEDORA-2023-dc0b65d976 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2023-88a95f3a92 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.