Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 219050

Summary:	Review Request: gaim-libnotify - Libnotify Gaim plugin
Product:	[Fedora] Fedora	Reporter:	Peter Gordon <peter>
Component:	Package Review	Assignee:	Mamoru TASAKA <mtasaka>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-12-10 18:33:25 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779

Description Peter Gordon 2006-12-10 03:59:55 UTC

Spec URL: http://thecodergeek.com/downloads/fedora/gaim-libnotify.spec
SRPM URL: http://thecodergeek.com/downloads/fedora/gaim-libnotify-0.12-1.src.rpm
Description: gaim-libnotify is a plugin for the open-source Gaim instant messaging client that
uses libnotify to display graphic notifications of new messages and other
events such as a buddy signing on or off.

This was previously submitted in bug #211834, but the reporter (Jon Nettleton) decided that "this entire process is a bit much for [him]." However, I find it to be a very nice replacement for Guifications, and so would like to see it in Extras.

Comment 1 Mamoru TASAKA 2006-12-10 04:57:27 UTC

*** Bug 211834 has been marked as a duplicate of this bug. ***

Comment 2 Mamoru TASAKA 2006-12-10 07:36:34 UTC

Well,

For http://fedoraproject.org/wiki/Packaging/Guidelines :
* Use rpmlint
  - rpmlint complains:
---------------------------------------------------------
[root@localhost mock]# rpmlint gaim-libnotify
E: gaim-libnotify description-line-too-long gaim-libnotify is a plugin for the
open-source Gaim instant messaging client that
[root@localhost mock]# rpmlint gaim-libnotify
E: gaim-libnotify description-line-too-long gaim-libnotify is a plugin for the
open-source Gaim instant messaging client that
[root@localhost mock]# rpmlint -I description-line-too-long
description-line-too-long :
Your description lines must not exceed 79 characters. If a line is exceeding
this number, cut it to fit in two lines.
---------------------------------------------------------

* File and Directory Ownership
  - /usr/lib/gaim
  This directory is not owned by any package required by this
  rpm. This package should need gaim as Requires.

* BuildRequires
  - Why does this package need
    gettext perl-XML-Parser
    as BuildRequires? Mockbuild for FC-devel i386 is fine without
    these two packages.

Comment 3 Peter Gordon 2006-12-10 08:15:10 UTC

(In reply to comment #2)
> [root@localhost mock]# rpmlint gaim-libnotify
> E: gaim-libnotify description-line-too-long gaim-libnotify is a plugin for the
> open-source Gaim instant messaging client that
> [root@localhost mock]# rpmlint gaim-libnotify
> E: gaim-libnotify description-line-too-long gaim-libnotify is a plugin for the
> open-source Gaim instant messaging client that
> [root@localhost mock]# rpmlint -I description-line-too-long
> description-line-too-long :
> Your description lines must not exceed 79 characters. If a line is exceeding
> this number, cut it to fit in two lines.

Gaah I didn't see that expansion of the %name macro would push it past this
limit. I've fixed this in release 2 (0.12-2).


* File and Directory Ownership
>   - /usr/lib/gaim
>   This directory is not owned by any package required by this
>   rpm. This package should need gaim as Requires.

Thanks for catching that. Fixed in 0.12-2

> * BuildRequires
>   - Why does this package need
>     gettext perl-XML-Parser
>     as BuildRequires? Mockbuild for FC-devel i386 is fine without
>     these two packages.

I put those in as the first ones in the spec mostly of habit when I saw that
gettext was being used for the translation foo, but then forgot to test whether
or not they were actually needed. >_> Thanks for checking this; and they're gone
in 0.12-2.

Spec: http://thecodergeek.com/downloads/fedora/gaim-libnotify.spec
Source RPM: http://thecodergeek.com/downloads/fedora/gaim-libnotify-0.12-2.src.rpm

Thanks for your time.

Comment 4 Mamoru TASAKA 2006-12-10 12:40:58 UTC

Well, please consider to add "TODO" to %doc entry.
Other things are all okay.

----------------------------------------------
  This package (gaim-libnotify) is APPROVED by me.

Comment 5 Peter Gordon 2006-12-10 18:33:25 UTC

Imported into CVS (with TODO added to %doc); branch requested for FC-6, and the
build for devel/FC7 is churning through the build system now.

Thanks for your review and comments!