Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 219114

Summary:	Review Request: flac123 - Command-line program for playing FLAC audio files
Product:	[Fedora] Fedora	Reporter:	Sindre Pedersen Bjørdal <sindrepb>
Component:	Package Review	Assignee:	Parag AN(पराग) <panemade>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	opensource
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-12-28 18:00:40 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779

Description Sindre Pedersen Bjørdal 2006-12-11 03:16:42 UTC

Spec URL: http://folk.ntnu.no/sindrb/packages/flac123.spec
SRPM URL: http://folk.ntnu.no/sindrb/packages/flac123-0.0.9-1.src.rpm

Description: 

flac123 is a command-line program for playing FLAC audio files

FLAC stands for Free Lossless Audio Codec. Grossly oversimplified, FLAC
is similar to Ogg Vorbis, but lossless

Comment 1 Parag AN(पराग) 2006-12-11 05:15:09 UTC

packaging is ok.
rpmlint is silent.
Is grip is also in extras?
where can i find files that i can play with flac123?

Comment 2 Till Maas 2006-12-11 07:28:47 UTC

(In reply to comment #1)
> where can i find files that i can play with flac123?

You can create them with flac (in package flac) from .wav files.

Comment 3 Parag AN(पराग) 2006-12-26 05:09:59 UTC

Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and RPMS.
+ source files md5sum. No upstream is available.
1614e1d1fe5b427ffd5988ea766abcf4  flac123-0.0.9.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.  License text included in package.
+ %doc is small; no -doc subpackage required.
+ %doc does not affect runtime.
+ COPYING included in %doc.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel or any subpackages exists
+ no .la files.
+ no translations are available
+ Dose owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
APPROVED.

Comment 4 Parag AN(पराग) 2006-12-27 05:04:17 UTC

Don't forget to CLOSE this review after you finished building package in CVS.