Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 219575 (php-pear-File)

Summary:	Review Request: php-pear-File - Common file and directory routines
Product:	[Fedora] Fedora	Reporter:	Christopher Stone <chris.stone>
Component:	Package Review	Assignee:	Brandon Holbrook <fedora>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	Flags:	wtogami: fedora-cvs+
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-12-14 06:51:22 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779, 189195

Description Christopher Stone 2006-12-14 00:44:50 UTC

Spec URL: http://tkmame.retrogames.com/fedora-extras/php-pear-File.spec
SRPM URL: http://tkmame.retrogames.com/fedora-extras/php-pear-File-1.2.2-1.src.rpm

Description:
Provides easy access to read/write to files along with some common routines
to deal with paths. Also provides interface for handling CSV files.

Comment 1 Brandon Holbrook 2006-12-14 05:41:40 UTC

package meets naming and packaging guidelines.
specfile is properly named, is cleanly written and uses macros consistently.
dist tag is present.
build root is correct.
license field matches the actual license.
license is open source-compatible. License text included in package.
source files match upstream:
   ba8f020b70fb6a37c6258e0e42033aad  File-1.2.2.tgz
latest version is being packaged.
BuildRequires are proper.
rpmlint is silent.
final provides and requires are sane
no shared libraries are present.
package is not relocatable.
owns the directories it creates.
doesn't own any directories it shouldn't.
no duplicates in %files.
file permissions are appropriate.
%clean is present.
no %check is present
no scriptlets present.
code, not content.
documentation is small, so no -docs subpackage is necessary.
%docs are not necessary for the proper functioning of the package.
no headers.
no pkgconfig files.
no libtool .la droppings.
not a GUI app.
not a web app.

Very standard PEAR package, everything check out - APPROVED.

Comment 2 Christopher Stone 2006-12-14 06:51:22 UTC

Built for devel.  Added entry on CVS sync page for FC-5/6.  Updated owners.list.
 Thanks for the review.

BTW, this bug was not set to block FE-ACCEPT.  I'll go ahead and do that for you
now.

Comment 3 Christopher Stone 2007-04-25 22:10:37 UTC

Package Change Request
======================
Package Name: php-pear-File
New Branches: EL-5