Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 219873
Summary: | Review Request: kio_sword - lightweight Sword front-end for KDE | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | David Anderson <fedora-packaging2> |
Component: | Package Review | Assignee: | Deji Akingunola <dakingun> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | chitlesh, rdieter |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2007-01-16 00:03:03 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
David Anderson
2006-12-15 20:25:21 UTC
Spec URL: http://david.dw-perspective.org.uk/tmp/kio_sword.spec SRPM URL: http://david.dw-perspective.org.uk/tmp/kio_sword-0.2-2.fc5.src.rpm #1. Parallel make should be used see http://fedoraproject.org/wiki/Packaging/Guidelines#head-525c7d76890cb22df33b759c65c35c82bf434d2e #2. gcc-c++ is among the exceptions, remove it from BR see http://fedoraproject.org/wiki/Packaging/Guidelines#head-4cadce5e79d38a63cad3941de1dadc9d25d67d30 #3: is there a specific reason why you used: [ -n "$RPM_BUILD_ROOT" -a "$RPM_BUILD_ROOT" != / ] && %{__rm} -rf --preserve-root $RPM_BUILD_ROOT The buildroot is already defined. #4: you should use see: Scriptlets http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#head-7103f6c38d1b5735e8477bdd569ad73ea2c49bda #5: during rpmbuild, I have: /var/tmp/rpm-tmp.59067: line 30: kdeconfig: command not found + export KDEDIR= + KDEDIR= is it useful to use kdeconfig ? Thanks for the review. All issues have been addressed: New versions (note the upstream version bump): Spec URL: http://david.dw-perspective.org.uk/tmp/kio_sword.spec SRPM URL: http://david.dw-perspective.org.uk/tmp/kio_sword-0.3-1.fc5.src.rpm Fixed 1, 2, 3, 4. (The reason for #3 was paranoia). For 5, the value of it is used in the autoconf scripts in the tarball. (My error in using kdeconfig instead of kde-config (now fixed) was leading to a pre-programmed default being used, which happened to be the right thing). (In reply to comment #0) > This is my first package - I am seeking a sponsor. (Just noticing that now I am sponsoring and currently this bug does not block FE-NEEDSPONSOR) Hi David, A couple of needswork and nitpicks, NEEDSWORK: * Packages doesn't build in x86_64 mock * Needs to call ldconfig in post and postun * Ought to use the %find_lang for locales/translations * Packages must NOT contain any .la libtool archives NITS: * You should really require sword >=1.5.8 * Setting the CFLAGS in the spec is not necessary, it's already set by rpmbuild * Also setting the $PATH for QT is not necesaary, already done /etc/profile.d/qt.sh (I notice you only set this variables, you didn't export them) * I'm not sure what '--preserve-root' option does when you clean the buildroot, but I think its unnecesary. * I'm not Thanks, Deji. New files: Spec URL: http://david.dw-perspective.org.uk/tmp/kio_sword.spec SRPM URL: http://david.dw-perspective.org.uk/tmp/kio_sword-0.3-2.src.rpm > NEEDSWORK: > * Packages doesn't build in x86_64 mock Fixed using patch (thanks again!). > * Needs to call ldconfig in post and postun > * Packages must NOT contain any .la libtool archives I don't believe these two are true. All kioslaves need the libtool archive and won't work without them. Fedora ships these in kdebase for the standard kioslaves. (I believe that in KDE4 they'll go away). > * Ought to use the %find_lang for locales/translations There's no localisation upstream, so this is a no-op, but I've implemented it anyway (as I believe upstream is introducing it in future). > NITS: > * You should really require sword >=1.5.8 Done. > * Setting the CFLAGS in the spec is not necessary, it's already set by rpmbuild Removed. > * Also setting the $PATH for QT is not necesaary, already done /etc/profile.d/qt.sh Removed. > * I'm not sure what '--preserve-root' option does when you clean the buildroot, but I think its unnecesary. Paranoia - it tells "rm" to cancel the command if told to "rm -rf /" ! Anyway, gone now. > kioslaves need the libtool archive
yup, for now anyway, until kde(kdelibs) is fixed/patched to do otherwise.
(In reply to comment #4) > (In reply to comment #0) > > This is my first package - I am seeking a sponsor. > > (Just noticing that now I am sponsoring and currently > this bug does not block FE-NEEDSPONSOR) I've blocked this bug as FE-NEEDSPONSOR. Deji Akingunola, are you sponsoring? Hi Chitlesh, I think Mamoru fixed that in comment #4 Confirmed - Mamoru Tasaka is my sponsor (curlftpfs, my first package, is already in Extras). I don't need a sponsor any more for this. Thanks for such info :) Almost done, rpmlint is not satisfactorily silent on the binary rpm
[deji@agape deji]$ rpmlint kio_sword-0.3-2.fc7.x86_64.rpm
W: kio_sword dangling-symlink /usr/share/doc/HTML/en/kio_sword/common
/usr/share/doc/HTML/en/common
W: kio_sword symlink-should-be-relative /usr/share/doc/HTML/en/kio_sword/common
/usr/share/doc/HTML/en/common
The first can be ignored (knowing the target is there), the following patch fix
the second warning;
>>
--- kio_sword.spec 2007-01-13 01:13:05.000000000 -0500
+++ kio_sword.spec.new 2007-01-13 01:16:41.000000000 -0500
@@ -37,6 +37,11 @@
make DESTDIR=$RPM_BUILD_ROOT install
+#Fix symlink relative
+pushd $RPM_BUILD_ROOT%{_datadir}/doc/HTML/en/kio_sword/
+ln -sf ../common common
+popd
+
%find_lang kio_sword || touch kio_sword.lang
HTML_DIR=$(kde-config --expandvars --install html)
if [ -d $RPM_BUILD_ROOT/$HTML_DIR ]; then
<<
I'm sorry that patch should really look like below;
>>
--- /home/deji/Desktop/kio_sword-0.3-2.src.rpm_FILES/kio_sword.spec
2007-01-13 01:48:38.000000000 -0500
+++ kio_sword.spec 2007-01-13 01:32:54.000000000 -0500
@@ -37,6 +37,12 @@
make DESTDIR=$RPM_BUILD_ROOT install
+#Fix symlink to be relative
+rm -rf $RPM_BUILD_ROOT%{_datadir}/doc/HTML/en/kio_sword/common
+pushd $RPM_BUILD_ROOT%{_datadir}/doc/HTML/en/kio_sword/
+ln -s ../common common
+popd
+
%find_lang kio_sword || touch kio_sword.lang
HTML_DIR=$(kde-config --expandvars --install html)
if [ -d $RPM_BUILD_ROOT/$HTML_DIR ]; then
<<
I guess its time to go to bed.
Thanks again, Deji. Patch added. New files: Spec URL: http://david.dw-perspective.org.uk/tmp/kio_sword.spec SRPM URL: http://david.dw-perspective.org.uk/tmp/kio_sword-0.3-3.src.rpm Personally I'm not sure of whether silencing trivial rpmlint warnings is any better than cluttering up the specfile, but seeing as you've helped me so much I'll go with you! (In reply to comment #14) > Personally I'm not sure of whether silencing trivial rpmlint warnings is any > better than cluttering up the specfile, I agree with you, but the packaging guildeline says the rpmlint must be satisfied as much as possible, "for thus it becometh us to fulfill all righteousness" ;). GOOD: * rmplint silent mock built binary * rpmlint warning on srpm can be ignored; (W: kio_sword dangling-relative-symlink /usr/share/doc/HTML/en/kio_sword/common ../common) * source tarball matches upstream's md5sum: 957c563737d47900f67661086732ee12 kio_sword-0.3.tar.gz * package name meets the Package Naming Guidelines. * Satifies the Packaging Guidelines. * Builds in mock (x86_64 development) * Installs OK * License: GPL * Spec file generally OK. It includes a .la, but that's OK for kde packages for now (coments #6 & #7) APPROVED. Thanks to all who have helped. |