Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 219915
Summary: | Review Request: kio_resources - Kio_resources provides the "resources" protocol for KDE | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Chitlesh GOORAH <chitlesh> |
Component: | Package Review | Assignee: | Rex Dieter <rdieter> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora, rdieter |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2007-01-03 12:54:20 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Chitlesh GOORAH
2006-12-16 11:10:01 UTC
== Not an official review as I'm not yet sponsored == The spec file seems to be ok. rpmlint's out is clean, packages build correctly with mock. It is prereview, I am not sponsored. Rpmlint return NULL, so OK. I didn't check build with mock, but under normal user it built correct. I think You should use macros in source-url. 26521-kio_resources-0.2.tar.bz2 change for example: 26521-%(name)-%{version}.tar.bz2 And the last: Is kdebase realy needed by this package? (In reply to comment #2) > I think You should use macros in source-url. > 26521-kio_resources-0.2.tar.bz2 > change for example: > 26521-%(name)-%{version}.tar.bz2 to please you, I'll modify it for the next release since it is not really a blocker > And the last: Is kdebase realy needed by this package? This package is useless without konqueror chitlesh(~)[1]$whereis konqueror konqueror: /usr/bin/konqueror chitlesh(~)[1]$rpm -qf /usr/bin/konqueror kdebase-3.5.5-0.4.fc6 I'll review this. Pretty simple and straight-forward. * builds in mock environment. * MUST: SOURCE matches upstream APPROVED. I'll leave these up to you to consider: * SHOULD: Summary shouldn't include pkg name (ie, don't include Kio_resources) * SHOULD: Description is too long, imo. Could probably omit 2nd paragraph. Thanks Rex :) * Mon Jan 01 2007 Chitlesh Goorah <chitlesh [AT] fedoraproject DOT org> - 0.2-2 - Removed package name from summary - Fixed description, since it was too long |