Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 219956

Summary:	Review Request: perl-IO-Capture - Abstract Base Class to build modules to capture output
Product:	[Fedora] Fedora	Reporter:	Jose Pedro Oliveira <jose.p.oliveira.oss>
Component:	Package Review	Assignee:	Ville Skyttä <ville.skytta>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-12-18 15:57:30 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779

Description Jose Pedro Oliveira 2006-12-17 18:17:32 UTC

Spec URL:
ftp://perl.di.uminho.pt/pub/fedora/perl-IO-Capture.spec

SRPM URL:
ftp://perl.di.uminho.pt/pub/fedora/perl-IO-Capture-0.05-1.src.rpm

Description:
The IO::Capture Module defines an abstract base class that can be used
to create any number of useful sub-classes that capture output being
sent on a filehandle such as STDOUT or STDERR.

Note: this module will help improving the test coverage of Perl::Critic
(Module::CPANTS::Analyse --> Test::Kawlitee --> Perl::Critic)

Comment 1 Ville Skyttä 2006-12-17 18:36:20 UTC

Approved, please just fix the order of arguments to find(1) in %install (-depth
before -type d) before the first build, see spectemplate-perl.spec in rpmdevtools.

$ find /tmp -type d -depth -name foo >/dev/null
find: warning: you have specified the -depth option after a non-option argument
-type, but options are not positional (-depth affects tests specified before it
as well as those specified after it).  Please specify options before other
arguments.

$ find /tmp -depth -type d -name foo >/dev/null
(no warnings)

Comment 2 Jose Pedro Oliveira 2006-12-17 19:46:45 UTC

(In reply to comment #1)
> Approved, please just fix the order of arguments to find(1) in %install (-depth
> before -type d) before the first build, see spectemplate-perl.spec in rpmdevtools.

Done.

Packaged imported and built (only devel at the moment). I will close
this ticket as soon as this package gets built for FC-5 and FC-6.

Thanks for the review,
jpo

Comment 3 Jose Pedro Oliveira 2006-12-18 15:57:30 UTC

Also built for FC-5 and FC-6.