Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 220703
Summary: | Review Request: libgtksourceviewmm - A C++ wrapper for the gtksourceview widget library | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Damien Durand <splinux25> |
Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | mtasaka |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2007-01-29 17:15:09 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Damien Durand
2006-12-23 17:53:07 UTC
A quick note: * /usr/lib/gtksourceviewmm-1.0 should be in -devel package. * The existence of /usr/lib/pkgconfig/libgtksourceviewmm-1.0.pc and its contents means that -devel package should Require some other packages (pkgconfig + else). Check "Requires" section of http://fedoraproject.org/wiki/Packaging/Guidelines Oops.. Also: * COPYING must be in main package. I think AUTHORS should also be in main package (and also README?) * ChangeLog, NEWS should be added in -devel package. New Spec file : http://glive.tuxfamily.org/fedora/libgtksourceviewmm/libgtksourceviewmm.spec New SRPM file : http://glive.tuxfamily.org/fedora/libgtksourceviewmm/libgtksourceviewmm-0.2.0-2.src.rpm - add libdir/gtksourceviewmm-1.0 in devel package - add Changelog and NEWS in devel package - add gtkmm24-devel and gtksourceview-devel in devel package Well, * I think adding "pkgconfig" to Requires for -devel package is safe for .pc file * I didn't notice it, however, this is licensed under LGPL, not GPL... Additional comment: Inclusion of m4 file usually means that -devel package should require automake. ping? Sorry for the delay SPEC file : http://glive.tuxfamily.org/fedora/libgtksourceviewmm/libgtksourceviewmm.spec SRPMS : http://glive.tuxfamily.org/fedora/libgtksourceviewmm/libgtksourceviewmm-0.2.0-3.src.rpm - add automake and pkgconfig in devel package Okay. All issues are now fixed correctly. One issue. * Timestamps - -devel package contains many header files and keeping timestamps on these files are recommended. Please use --------------------------------------- make INSTALL="install -c -p" DESTDIR=$RPM_BUILD_ROOT install ---------------------------------------- Other things are okay. ----------------------------------------- This package (libgtksoureviewmm) is APPROVED by me. (Please close this bug as CLOSED NEXTRELEASE when rebuilding is done) (Closing as NEXTRELEASE as this is already imported into FE-devel/6. If there is any problem, please let me know it.) |