Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 220944

Summary:	Review Request: perl-Text-WrapI18N - Line wrapping with support for several locale setups
Product:	[Fedora] Fedora	Reporter:	Axel Thimm <axel.thimm>
Component:	Package Review	Assignee:	manuel wolfshant <wolfy>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2007-01-07 02:05:32 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	220945
Bug Blocks:	163779, 220943

Description Axel Thimm 2006-12-29 12:19:24 UTC

Spec URL: http://dl.atrpms.net/all/perl-Text-WrapI18N.spec
SRPM URL: http://dl.atrpms.net/all/perl-Text-WrapI18N-0.06-1.at.src.rpm
Description:

This is a module which intends to substitute Text::Wrap,
which supports internationalized texts including:
 - multibyte encodings such as UTF-8, EUC-JP, EUC-KR, GB2312, and Big5,
 - fullwidth characters like east Asian characters which appear in
   UTF-8, EUC-JP, EUC-KR, GB2312, Big5, and so on,
 - combining characters like diacritical marks which appear in UTF-8,
   ISO-8859-11 (aka TIS-620), and so on, and
 - languages which don't use whitespaces between words, like Chinese
   and Japanese.

Comment 1 Axel Thimm 2007-01-01 14:42:26 UTC

Spec URL: http://dl.atrpms.net/all/perl-Text-WrapI18N.spec
SRPM URL: http://dl.atrpms.net/all/perl-Text-WrapI18N-0.06-2.at.src.rpm

* Sat Dec 30 2006 Axel Thimm <Axel.Thimm> - 0.06-2
- Add ownership of some perl folders.

Comment 2 Parag AN(पराग) 2007-01-02 04:31:30 UTC

I am unable to download SPEC and SRPMS files.

Comment 3 Axel Thimm 2007-01-02 11:09:56 UTC

Sorry, they were moved internally (into my "submit to extras folder") while the
site building scripts were running and they missed it. They have been
resurrected now, please retry.

Comment 4 Peter Gordon 2007-01-04 21:10:09 UTC

I'll review this when I get home from work tonight.

Comment 5 Peter Gordon 2007-01-05 03:51:55 UTC

[ Withdrawing myself as reviewer of this package due to BuildRoot disagreements.
See bug #220888 comment 15 for information. ]

Comment 6 manuel wolfshant 2007-01-05 13:50:22 UTC

I'll review this one ASAP, probably Sunday

Comment 7 manuel wolfshant 2007-01-06 11:51:16 UTC

Good:

- rpmlint on source rpm returns:
E: perl-Text-WrapI18N unknown-key GPG#66534c2b
which can safely be ignored
- no output from rpmlint on the generated binary
- package meets packaging guidelines, except for the %buildroot which is not the
preferred value (but non blocker)
- the original tar does not include a license file but the (packaged) README
explicitely states that the software is dual licensed as GPL and Artistic (also
used by Perl in which the source is written) which are both approved for
inclusion in Fedora
- the License field corresponds to the above and therefore is OK
- spec file legible, in am. english
- source is latest version, matches upstream, sha1sum returns
f397756b8d0a090fdecbf9c854922c0d9825f284  Text-WrapI18N-0.06.tar.gz
- compiles in mock for devel i386; it's a noarch so no potential need for
exclusion on unsupported archs
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions are sane
- %clean ok
- macro use consistent
- code, not content
- no need for separate -docs package
- nothing in %doc affects runtime
- no need for .desktop file
- no header, static, .pc files
- no scriptlets

SHOULD
- builds in mock, creates a noarch
- the generated package can successfully be used by other programs (po4a)

APPROVED

Comment 8 Axel Thimm 2007-01-07 02:05:32 UTC

Thanks, package imported, built for devel and CVS branches requested.