Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 221163

Summary: Review Request: qwtplot3d - Qt/OpenGL-based C++ library providing a bunch of 3D-widgets for programmers
Product: [Fedora] Fedora Reporter: Julian Sikorski <belegdol>
Component: Package ReviewAssignee: Michał Bentkowski <mr.ecik>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Package Reviews List <fedora-package-review>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: chitlesh
Target Milestone: ---Flags: kevin: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2007-01-06 22:30:41 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 163779    

Description Julian Sikorski 2007-01-02 17:05:40 UTC
Spec URL: http://www.republika.pl/belegdol/rpmstuff/qwtplot3d.spec
SRPM URL: http://www.republika.pl/belegdol/rpmstuff/qwtplot3d-0.2.6-1.src.rpm
Description: QwtPlot3D is not a  program, but a feature-rich Qt/OpenGL-based C++ programming library, providing essentially a  bunch of 3D-widgets for programmers

It is needed at least by LabPlot. I have managed to get rpmlint silent apart from one, harmless error. Package builds in mock (fc6/i386).

Comment 1 Michał Bentkowski 2007-01-02 18:22:13 UTC
(In reply to comment #0)
> It is needed at least by LabPlot. I have managed to get rpmlint silent apart 
from one, harmless error. Package builds in mock (fc6/i386).

On fc6/x86_64 it builds as well.

I'll make a full review later.

Comment 2 Michał Bentkowski 2007-01-02 18:49:37 UTC
REVIEW:
 * rpmlint is not quiet:
E: qwtplot3d-devel only-non-binary-in-usr-lib
but we can ignore that until a file in /usr/lib is symlink to a binary one
 * sources match upstream (7ef960d7874f78162d6c9d241de2843e)
 * BRs listed well (mock builds fine)
 * license is in fact zlib/libpng (checked)
!* -devel subpackage present, but needs to be improved
 * name of package is good as well as spec file name
 * proper %post and %postun sections
 * package isn't designed to be relocatable
 * there's no duplicates in %files section
 * package owns files and directories well
 * proper %clean section
 * %defattr macros are present
 * macros are used good

THING TO DO:
 - some header files include files like a qstringlist.h which are owned by
qt-devel package. Thus you have to add qt-devel dependency to -devel subpackage.


Comment 3 Julian Sikorski 2007-01-02 19:50:36 UTC
Spec URL: http://www.republika.pl/belegdol/rpmstuff/qwtplot3d.spec
SRPM URL: http://www.republika.pl/belegdol/rpmstuff/qwtplot3d-0.2.6-2.src.rpm

New release:
- Added qt-devel to -devel subpackage requires

Comment 4 Michał Bentkowski 2007-01-02 20:41:33 UTC
Nothing to pick on.
Approved.

Comment 5 Julian Sikorski 2007-06-28 00:06:42 UTC
Package Change Request
======================
Package Name: qwtplot3d
Updated Fedora Owners: chitlesh

Comment 6 Kevin Fenzi 2007-06-28 19:38:23 UTC
I don't see that email address in the account system? Can you check it and resubmit?


Comment 7 Julian Sikorski 2007-06-29 08:40:18 UTC
Oops, sorry.

Package Change Request
======================
Package Name: qwtplot3d
Updated Fedora Owners: cgoorah.au

Comment 8 Kevin Fenzi 2007-06-29 21:11:54 UTC
Thanks. cvs done. 

Comment 9 Chitlesh GOORAH 2010-07-07 17:39:20 UTC
Package Change Request
======================
Package Name: qwtplot3d
New Branches: EL-6
Owners: chitlesh

Comment 10 Kevin Fenzi 2010-07-08 01:10:09 UTC
CVS done (by process-cvs-requests.py).