Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 221163
| Summary: | Review Request: qwtplot3d - Qt/OpenGL-based C++ library providing a bunch of 3D-widgets for programmers | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Julian Sikorski <belegdol> |
| Component: | Package Review | Assignee: | Michał Bentkowski <mr.ecik> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | chitlesh |
| Target Milestone: | --- | Flags: | kevin:
fedora-cvs+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-01-06 22:30:41 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779 | ||
|
Description
Julian Sikorski
2007-01-02 17:05:40 UTC
(In reply to comment #0) > It is needed at least by LabPlot. I have managed to get rpmlint silent apart from one, harmless error. Package builds in mock (fc6/i386). On fc6/x86_64 it builds as well. I'll make a full review later. REVIEW: * rpmlint is not quiet: E: qwtplot3d-devel only-non-binary-in-usr-lib but we can ignore that until a file in /usr/lib is symlink to a binary one * sources match upstream (7ef960d7874f78162d6c9d241de2843e) * BRs listed well (mock builds fine) * license is in fact zlib/libpng (checked) !* -devel subpackage present, but needs to be improved * name of package is good as well as spec file name * proper %post and %postun sections * package isn't designed to be relocatable * there's no duplicates in %files section * package owns files and directories well * proper %clean section * %defattr macros are present * macros are used good THING TO DO: - some header files include files like a qstringlist.h which are owned by qt-devel package. Thus you have to add qt-devel dependency to -devel subpackage. Spec URL: http://www.republika.pl/belegdol/rpmstuff/qwtplot3d.spec SRPM URL: http://www.republika.pl/belegdol/rpmstuff/qwtplot3d-0.2.6-2.src.rpm New release: - Added qt-devel to -devel subpackage requires Nothing to pick on. Approved. Package Change Request ====================== Package Name: qwtplot3d Updated Fedora Owners: chitlesh I don't see that email address in the account system? Can you check it and resubmit? Oops, sorry. Package Change Request ====================== Package Name: qwtplot3d Updated Fedora Owners: cgoorah.au Thanks. cvs done. Package Change Request ====================== Package Name: qwtplot3d New Branches: EL-6 Owners: chitlesh CVS done (by process-cvs-requests.py). |