Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 221665 (pear-Numbers-Roman)
Summary: | Review Request: php-pear-Numbers-Roman - Provides methods for converting to and from Roman Numerals | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Christopher Stone <chris.stone> |
Component: | Package Review | Assignee: | Brandon Holbrook <fedora> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | Flags: | wtogami:
fedora-cvs+
|
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2007-01-14 08:08:25 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Christopher Stone
2007-01-05 22:31:03 UTC
REVIEW: ======= OK - package meets naming and packaging guidelines. OK - specfile is properly named, is cleanly written and uses macros consistently. OK - dist tag is present. OK - build root is correct. OK - license field matches the actual license. OK - license is open source-compatible. ok - source files match upstream: 5103711a2e29d48a5ccda8ba1a11c893 Numbers_Roman-1.0.1.tgz 5103711a2e29d48a5ccda8ba1a11c893 Numbers_Roman-1.0.1.tgz OK - latest version is being packaged. OK - BuildRequires are proper. OK - package builds in mock OK - rpmlint is silent. OK - final provides and requires are sane: OK - no shared libraries are present. OK - package is not relocatable. OK - owns the directories it creates. OK - doesn't own any directories it shouldn't. OK - no duplicates in %files. OK - file permissions are appropriate. OK - %clean is present. OK - %check is not present, no tests included by upstream OK - pear scriptlets are standard OK - code, not content. OK - documentation is small, so no -docs subpackage is necessary. OK - no headers. OK - no pkgconfig files. OK - no libtool .la droppings. OK - not a GUI app. Cut-and-dry pear package. APPROVED. - imported in cvs - added entry to owners.list - tagged and built for devel - requested cvs sync for FC5/6 THANKS FOR THE REVIEW! Package Change Request ====================== Package Name: php-pear-Numbers-Roman New Branches: EL-5 |