Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 222555 (tango-icons-extras)
Summary: | Review Request: tango-icon-theme-extras - Extra icons from the Tango Project | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Peter Gordon <peter> |
Component: | Package Review | Assignee: | Ruben Kerkhof <ruben> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | rdieter |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2007-01-30 02:22:11 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Peter Gordon
2007-01-14 04:01:33 UTC
[ Adding alias; though "tango-icon-theme-extras" exceeds the 20-character limit. ] Hi Peter, I'm happy to review your package. Look for a full review here in a bit. Ok, here we go. - package conforms to package naming guidlines - spec file name matches basename - the package is licensed with an open source compatible license - package includes license in %doc - spec file is written in american english - spec file is legible - sources match upstream (sha1sum) 1bed3023139187c36e851df19506f4942bf2d1c1 tango-icon-theme-extras-0.1.0.tar.gz 1bed3023139187c36e851df19506f4942bf2d1c1 tango-icon-theme-extras-0.1.0.tar.gz.1 - package successfully built on my test box (i386) - no need for exclude arch - BR are present and make sense - no libraries, no need to run ldconfig - not relocatable - package owns everything it creates - package does not duplicate files it owns - file attributes are set appropriatly - %clean section present and removes buildroot - consistently uses macros - no large documentation - files in %doc does not affect runtime of application - does not contain a pkgconfig file - does not contain any libraries - does not have a devel package - does not contain any .la files - package does not have a gui - package does not own files/directories owned by other packages. Peter, have you considered reporting the missing CC lincense to the rpmlint maintainer? I don't see any blockers, so this package is APPROVED. Just a comment: * BuildRequires ------------------------------------------- BuildRequires: ImageMagick-devel >= 5.5.7 BuildRequires: librsvg2-devel >= 2.12.3 ------------------------------------------- Check if "-devel" (not main) package is really required. From buildlog, rebuilding this needs "/usr/bin/convert" (in ImageMagick), /usr/bin/rsvg (librsvg2) are needed, however, -devel packages do not seem to be needed. Thanks for the review, Ruben! (In reply to comment #4) > BuildRequires: ImageMagick-devel >= 5.5.7 > BuildRequires: librsvg2-devel >= 2.12.3 > ------------------------------------------- > Check if "-devel" (not main) package is really required. > From buildlog, rebuilding this needs "/usr/bin/convert" > (in ImageMagick), /usr/bin/rsvg (librsvg2) are needed, > however, -devel packages do not seem to be needed. Much of this spec file is copied directly from the tango-icon-theme spec that is already in Extras. I will check on these BuildRequires when I return home tonight. :] Yup. I tried rebuilding it in mock with these BuildRequires changed to their base packages (ImageMagick and librsvg2 intead of the -devel subpackages); and the configure script fails because it uses pkg-config to ensure that the necessary versions of these two are installed. The relevent pkgconfig files are in the -devel packages, so these are needed. :) Thanks for the review; imported and closing as NEXTRELEASE. (And I've created bug #225354 to ask about adding that to the list of valid licenses.) |