Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 222593 (pear-Image-Graph)
Summary: | Review Request: php-pear-Image-Graph - Displays numerical data as a graph/chart/plot | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Christopher Stone <chris.stone> |
Component: | Package Review | Assignee: | Remi Collet <fedora> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | Flags: | fedora:
fedora-review+
wtogami: fedora-cvs+ |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2007-03-12 19:23:19 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Christopher Stone
2007-01-15 00:49:22 UTC
REVIEW : * source files match upstream: 4e3f338314fe0754970a896686875a5e Image_Graph-0.7.2.tgz * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct (second form). * license field matches the actual license. * license is open source-compatible (LGPL). * latest version is being packaged (0.7.2) * BuildRequires are proper. * %clean is present. * package builds in mock (FC6). * package installs properly * rpmlint is silent. * final provides are sane: php-pear(Image_Graph) = 0.7.2 php-pear-Image-Graph = 0.7.2-1.fc7 => final Requires are sane: php-pear(Image_Canvas) >= 0.3.0 php-pear(Numbers_Roman) php-pear(Numbers_Words) php-pear(PEAR) * %check is not present; * owns the directories it creates * no duplicates in %files. * file permissions are appropriate. * scriptlets are OK (pear install) * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. Tests works well and produce nice charts ;) only a font problem (Arial) with tests/freetype.php Most Examples works well. To avoid some warnign, Should change find docdir -exec sed -i 's/\r//' {} \; To find docdir -type f -exec sed -i 's/\r//' {} \; * APPROVED * New Package CVS Request ======================= Package Name: php-pear-Image-Graph Short Description: Displays numerical data as a graph/chart/plot Owners: chris.stone Branches: FC-5 FC-6 devel InitialCC: done - Added -type f to sed command - Checked in sources - Built on devel, FC-6 and FC-5 Thanks for the review! :D Package Change Request ====================== Package Name: php-pear-Image-Graph New Branches: EL-5 |