Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 222670
Summary: | Review Request: ksudoku - Sudoku game | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Rafał Psota <rafalzaq> |
Component: | Package Review | Assignee: | Christopher Stone <chris.stone> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | rdieter |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2007-01-17 20:57:45 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Rafał Psota
2007-01-15 16:48:39 UTC
==== REVIEW CHECKLIST ==== - rpmlint output clean - package named according to package naming guidelines - spec file name matches %{name} - meets packaging guidelines - licensed with open source compatible license - license matches actual license - license included in %doc - spec written in American english - spec file is legible - sources match upstream: (had to fix Source0 URL) d5fe20e9deda671dd15340f43ab4c4a3 ksudoku-0.3.tar.gz - successfully compiles and builds on FC-6 x86_64 - all build dependencies listed in BR - no locales - no shared libraries - not relocatable - package owns all directories it creates - package requires other packages for directories it does not create - no duplicates listed in %files - file permissions set properly - package contains proper %clean - macro usage is consistent - contains code - no large documentation - files in %doc do not affect runtime - no header files or static libraries - no pkgconfig files - no .so files - no need for devel subpackage - no .la files - contains proper .desktop file - package does not own files or directories owned by other packages ==== MUST FIX ==== - Change Source0 to: http://dl.sourceforge.net/%{name}/%{name}-%{version}.tar.gz - /usr/share/doc/HTML needs to be in %doc ==== SHOULD FIX ==== - Add comments above sed commands explaining what you are doing - Add comments above the rm command for HTML/common explaining what you are doing (In reply to comment #1) > ==== MUST FIX ==== > - Change Source0 to: > http://dl.sourceforge.net/%{name}/%{name}-%{version}.tar.gz > - /usr/share/doc/HTML needs to be in %doc > > ==== SHOULD FIX ==== > - Add comments above sed commands explaining what you are doing > - Add comments above the rm command for HTML/common explaining what you are doing > Fixed. rpmlint returns W: ksudoku dangling-relative-symlink /usr/share/doc/HTML/en/ksudoku/common ../common because ksudoku doesn't contain this directory (kdelibs does). Spec URL: http://rafalzaq.nonlogic.org/fedora/ksudoku/ksudoku.spec SRPM URL: http://rafalzaq.nonlogic.org/fedora/ksudoku/ksudoku-0.3-2.src.rpm Oops I am sorry, I forgot to also mention that /usr/share/doc/HTML needs to be moved to /usr/share/doc/%{name}-%{version}/HTML > /usr/share/doc/HTML needs to be in %doc
FYI, everything under %{_docdir} is *automatically* marked %doc by rpm. (:
(In reply to comment #3) > Oops I am sorry, I forgot to also mention that /usr/share/doc/HTML needs to be > moved to /usr/share/doc/%{name}-%{version}/HTML > This is a part of KDE help system and AFAIK it doesn't work in different path (I mean opening it with Help menu → ksudoku Handbook not manually). I see, I did not realize this was a KDE directory. Package looks fine. My mistake. APPROVED |