Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 223068

Summary: Review Request: perl-MooseX-Object-Pluggable - Make your Moose classes pluggable
Product: [Fedora] Fedora Reporter: Chris Weyl <cweyl>
Component: Package ReviewAssignee: Parag AN(पराग) <panemade>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Package Reviews List <fedora-package-review>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhide   
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
URL: http://search.cpan.org/dist/MooseX-Object-Pluggable/
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2007-01-24 17:23:12 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 163779    

Description Chris Weyl 2007-01-17 19:18:05 UTC 
SRPM URL: http://home.comcast.net/~ckweyl/perl-MooseX-Object-Pluggable-0.0002-1.fc6.src.rpm
SPEC URL: http://home.comcast.net/~ckweyl/perl-MooseX-Object-Pluggable.spec

Description:
This module aids in the development and deploment of plugin-enabled
Moose-based classes.  It extends the Moose framework via a roles to enable
this behavior.
Comment 1 Parag AN(पराग) 2007-01-22 06:59:13 UTC 
Ooops where can i get dependency rpm perl(Moose)?
Comment 2 Ralf Corsepius 2007-01-22 07:39:25 UTC 
(In reply to comment #1)
> Ooops where can i get dependency rpm perl(Moose)?

It's in extras.

yum install 'perl(Moose)'
Comment 3 Parag AN(पराग) 2007-01-22 11:05:38 UTC 
(In reply to comment #2)
> (In reply to comment #1)
> > Ooops where can i get dependency rpm perl(Moose)?
> 
> It's in extras.
> 
> yum install 'perl(Moose)'

thanks. I was using old local extras repo. Thats why i faced that problem.
Comment 4 Parag AN(पराग) 2007-01-22 11:08:14 UTC 
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream.
b02e2baf09176b453e1b5abcde830144  MooseX-Object-Pluggable-0.0002.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Dose owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0,
'inc', 'blib/lib', 'blib/arch')" t/00-load.t t/01-basic.t t/boilerplate.t
t/pod-coverage.t t/pod.t
t/00-load.........ok 1/1# Testing MooseX::Object::Pluggable 0.0002, Perl
5.008008, /usr/bin/perl
t/00-load.........ok
t/01-basic........ok
t/boilerplate.....ok
t/pod-coverage....t/pod-coverage.t does not exist
t/pod.............ok
All tests successful.
Files=5, Tests=21,  1 wallclock secs ( 1.03 cusr +  0.05 csys =  1.08 CPU)

APPROVED.
Comment 5 Chris Weyl 2007-01-24 17:23:12 UTC 
Updated to 0.0004, imported and built on devel; branches requested for fc5,6.

Thanks for the review! :)