Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at

Bug 223486

Summary: Review Request: happy - Haskell parser generator
Product: [Fedora] Fedora Reporter: Bryan O'Sullivan <bos>
Component: Package ReviewAssignee: Jens Petersen <petersen>
Status: CLOSED RAWHIDE QA Contact: Fedora Package Reviews List <fedora-package-review>
Severity: urgent Docs Contact:
Priority: medium    
Version: rawhideCC: petersen
Target Milestone: ---Flags: petersen: fedora-review+
j: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2007-04-18 05:11:12 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 163779, 223490    
Description Flags
happy.spec-2.patch none

Description Bryan O'Sullivan 2007-01-19 17:33:09 UTC
Spec URL:

[This is my first Extras contribution, and I need a package sponsor.]

Happy is a parser generator system for Haskell, similar to the tool
`yacc' for C. Like `yacc', it takes a file containing an annotated BNF
specification of a grammar and produces a Haskell module containing a
parser for the grammar.

Happy is flexible: you can have several Happy parsers in the same
program, and several entry points to a single grammar. Happy can work
in conjunction with a lexical analyser supplied by the user (either
hand-written or generated by another program), or it can parse a
stream of characters directly (but this isn't practical in most

Comment 1 Jens Petersen 2007-02-16 07:48:38 UTC
Sorry for the slow review.  Here are some comments:

Rpmlint on the srpm gives:
W: happy redundant-prefix-tag

I think the dos2unix buildrequires can be dropped.

Otherwise it looks ok to me.

Comment 2 Jens Petersen 2007-02-16 07:52:23 UTC
Created attachment 148175 [details]

If you can update the package, then I will do a formal review. :)

Comment 3 Jens Petersen 2007-03-19 04:24:59 UTC
Ping :)

Comment 4 Bryan O'Sullivan 2007-03-26 04:04:16 UTC
Sorry for the delay.

Spec URL:

Comment 5 Jens Petersen 2007-03-26 07:14:24 UTC
Here is the review:

+ package and spec file are well named
+ meets Packaging Guidelines
+ package is open source (BSD-like)
+ license fields matches license and license file included in %doc
+ spec file is legible and in English
+ package built on i386
+ buildrequires listed
+ no translations
+ no libs included
+ owns its directories
+ no duplicates in filelist
+ has %clean
+ consistent use of macros
+ packages contains code
+ documentation small enough to be main package
+ no runtime files in %doc
+ no devel files
+ does not own dirs or files owned by other packages
+ installs and runs ok

Need attention:

- md5sum does not match upstream tarball, please use that
b9fd2f5eba61974dab8e12873cadee6f  happy-1.16.tar.gz

- rpmlint on srpm:
W: happy strange-permission happy.spec 0600
- rpmlint from binary package
W: happy wrong-file-end-of-line-encoding
W: happy wrong-file-end-of-line-encoding
W: happy wrong-file-end-of-line-encoding
W: happy wrong-file-end-of-line-encoding
W: happy wrong-file-end-of-line-encoding
W: happy wrong-file-end-of-line-encoding
W: happy wrong-file-end-of-line-encoding
W: happy wrong-file-end-of-line-encoding
W: happy wrong-file-end-of-line-encoding

Maybe worth addressing: not sure how useful the examples are to include.
They could also be dropped?

- missing disttag
Please suffix %{?dist} to the release field.

- description
Maybe remove "or it can parse a stream of characters directly (but this isn't
practical in most cases)"?

Comment 6 Jens Petersen 2007-03-26 07:17:54 UTC
Created attachment 150871 [details]

Comment 7 Jens Petersen 2007-03-26 07:19:14 UTC
attached some minor additional suggested fixes

Comment 8 Bryan O'Sullivan 2007-03-27 00:06:13 UTC
Jens, I've incorporated all of your suggestions, and the source and binary
packages now both pass rpmlint completely cleanly.  Please see the new spec and
SRPM at the URLs in comment #4.

Comment 9 Jens Petersen 2007-03-27 02:36:19 UTC
Ok, thanks for the updated package.  (BTW in the future please bump the release
field, since that makes it easier for the reviewer to look at the changes.)

All points have been addressed, the package looks good to me.

Package is APPROVED.

Do you still need sponsorship?  I would be happy to sponsor you if you
can do at least one pre-review of a package waiting to be reviewed.  Have
you already applied for a fedora account?

Comment 10 Bryan O'Sullivan 2007-03-27 02:50:30 UTC
Thanks for the approval.

Yes, I still need sponsorship.  I'll point you at a pre-reviewed package in a
few hours.  I *just* applied for a Fedora account (username bos).

Comment 11 Bryan O'Sullivan 2007-03-27 03:19:23 UTC
For a package review, see

Comment 12 Jens Petersen 2007-03-27 03:42:40 UTC
You need to follow
to do a complete review.  (When doing a pre-review - since you need to be
a Contributor to do formal reviews - it is good to comment in the bug
that it is a pre-review, so the submitter knows it is a pre-review.)
Sorry the process is still a bit involved, but this is because (currently)
every fedora contributor can review and approve new packages.

Comment 13 Jens Petersen 2007-03-27 03:50:22 UTC
Anyway your comments look ok so far: while your Fedora Account is being processed,
you can wait for the submitter to update the package.

Comment 14 Bryan O'Sullivan 2007-04-13 22:17:19 UTC
New Package CVS Request
Package Name: happy
Short Description: Haskell parser generator
Owners: bos
Branches: FC-6
InitialCC: petersen

Comment 15 Jens Petersen 2007-04-14 12:23:44 UTC

Comment 16 Bryan O'Sullivan 2007-04-18 05:11:12 UTC
In devel now.

Comment 17 Jens Petersen 2010-10-05 04:36:49 UTC
Package Change Request
Package Name: happy
New Branches: el6
Owners: bos petersen
InitialCC: haskell-sig

Comment 18 Jason Tibbitts 2010-10-05 13:32:15 UTC
Git done (by process-git-requests).