Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 223490
Summary: | Review Request: alex - The lexer generator for Haskell | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Bryan O'Sullivan <bos> | ||||
Component: | Package Review | Assignee: | Jens Petersen <petersen> | ||||
Status: | CLOSED ERRATA | QA Contact: | Fedora Package Reviews List <fedora-package-review> | ||||
Severity: | medium | Docs Contact: | |||||
Priority: | medium | ||||||
Version: | rawhide | CC: | petersen | ||||
Target Milestone: | --- | Flags: | petersen:
fedora-review+
j: fedora-cvs+ |
||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | 2.1.0-5.fc7 | Doc Type: | Bug Fix | ||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2007-11-10 05:59:37 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | 223486 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Bryan O'Sullivan
2007-01-19 18:08:04 UTC
Basically this package also looks ok. I might suggest some minor cleanup of the .spec along the lines of happy.spec. I'll clean this up later this evening and point you at the results. Well, that took a while to get around to :-) Spec URL: http://www.red-bean.com/~bos/alex.spec SRPM URL: http://www.red-bean.com/~bos/alex-2.1.0-2.src.rpm Sorry for sitting on this so long. (In reply to comment #3) > SRPM URL: http://www.red-bean.com/~bos/alex-2.1.0-2.src.rpm (BTW this links seems to be broken.) Thanks for cleaning up - the rpmlint output is clean. :) Created attachment 157731 [details]
alex.spec-2-fixes.patch
simplify buildrequires and build:
- happy, docbook-dtds, libxml2, xmltex not needed as buildrequires afaict
ping Jens, I've applied your patch with one change (still need to run autoreconf before ./configure in the doc directory). Thanks! This should be the final version of the package, I believe. http://www.red-bean.com/~bos/alex-2.1.0-3.fc7.src.rpm http://www.red-bean.com/~bos/alex.spec Here is the formal review: Good: + rpmlint clean + license is BSD + checked source md5sum: 17e80d39cc3f1aba28dcea0e358c81e9 alex-2.1.0.tar.gz + directory ownership good Needs attention: - need to exclude ppc64 for this too I guess. All other MUST items are satisfied. Could you please add the ppc64 excludes and open a bug for that making it depend on the ghc ppc64 bug. Package is APPROVED. PING This is still not built, right? Could you please put in a cvsadmin request? New Package CVS Request ======================= Package Name: alex Short Description: A tool for generating lexical analysers in Haskell Owners: bos, petersen Branches: F-7 InitialCC: Cvsextras Commits: yes cvs done. koji is choking due to ppc and ppc64 build failures. What should I do about this? http://koji.fedoraproject.org/koji/taskinfo?taskID=174765 Koji has been a bit unstable recently, please try again later after excluding ppc64 until ghc is available there. (It would be good to file a bug to track that too.) alex-2.1.0-5.fc7 has been pushed to the Fedora 7 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update alex' alex-2.1.0-5.fc7 has been pushed to the Fedora 7 stable repository. If problems still persist, please make note of it in this bug report. Package Change Request ====================== Package Name: alex New Branches: el6 Owners: bos petersen InitialCC: haskell-sig Git done (by process-git-requests). |