Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 223598
| Summary: | Review Request: liborigin - Library for reading OriginLab OPJ project files | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Chitlesh GOORAH <chitlesh> |
| Component: | Package Review | Assignee: | Deji Akingunola <dakingun> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | Flags: | kevin:
fedora-cvs+
|
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-02-04 19:16:53 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779 | ||
|
Description
Chitlesh GOORAH
2007-01-20 16:21:18 UTC
Hi, This package (its Makefile actually) needs to be patched up for rpmbuild to work properly on x86_64. It currently hard-codes the library path to /usr/lib. Also, can you make it use the rpm's %optflags for the CFLAGS? An Aside: What a version number ;), can't upstream use sth simple as 1.0 With the $RPM_OPT_FLAGS I'm having these:
g++ -c -pipe -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector --param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic
-fasynchronous-unwind-tables -Wall -W -O2 -fPIC OPJFile.cpp -o OPJFile.o
OPJFile.cpp: In member function 'int OPJFile::Parse()':
OPJFile.cpp:76: warning: ignoring return value of 'size_t fread(void*, size_t,
size_t, FILE*)', declared with attribute warn_unused_result
OPJFile.cpp:109: warning: ignoring return value of 'size_t fread(void*, size_t,
size_t, FILE*)', declared with attribute warn_unused_result
OPJFile.cpp:116: warning: ignoring return value of 'size_t fread(void*, size_t,
size_t, FILE*)', declared with attribute warn_unused_result
OPJFile.cpp:123: warning: ignoring return value of 'size_t fread(void*, size_t,
size_t, FILE*)', declared with attribute warn_unused_result
OPJFile.cpp:126: warning: ignoring return value of 'size_t fread(void*, size_t,
size_t, FILE*)', declared with attribute warn_unused_result
OPJFile.cpp:129: warning: ignoring return value of 'size_t fread(void*, size_t,
size_t, FILE*)', declared with attribute warn_unused_result
OPJFile.cpp:139: warning: ignoring return value of 'size_t fread(void*, size_t,
size_t, FILE*)', declared with attribute warn_unused_result
OPJFile.cpp:147: warning: ignoring return value of 'size_t fread(void*, size_t,
size_t, FILE*)', declared with attribute warn_unused_result
OPJFile.cpp:156: warning: ignoring return value of 'size_t fread(void*, size_t,
size_t, FILE*)', declared with attribute warn_unused_result
OPJFile.cpp:165: warning: ignoring return value of 'size_t fread(void*, size_t,
size_t, FILE*)', declared with attribute warn_unused_result
OPJFile.cpp:201: warning: ignoring return value of 'size_t fread(void*, size_t,
size_t, FILE*)', declared with attribute warn_unused_result
OPJFile.cpp:207: warning: ignoring return value of 'size_t fread(void*, size_t,
size_t, FILE*)', declared with attribute warn_unused_result
OPJFile.cpp:215: warning: ignoring return value of 'size_t fread(void*, size_t,
size_t, FILE*)', declared with attribute warn_unused_result
OPJFile.cpp:216: warning: ignoring return value of 'size_t fread(void*, size_t,
size_t, FILE*)', declared with attribute warn_unused_result
OPJFile.cpp:254: warning: ignoring return value of 'size_t fread(void*, size_t,
size_t, FILE*)', declared with attribute warn_unused_result
OPJFile.cpp:269: warning: ignoring return value of 'size_t fread(void*, size_t,
size_t, FILE*)', declared with attribute warn_unused_result
OPJFile.cpp:272: warning: ignoring return value of 'size_t fread(void*, size_t,
size_t, FILE*)', declared with attribute warn_unused_result
OPJFile.cpp:286: warning: ignoring return value of 'size_t fread(void*, size_t,
size_t, FILE*)', declared with attribute warn_unused_result
OPJFile.cpp:288: warning: ignoring return value of 'size_t fread(void*, size_t,
size_t, FILE*)', declared with attribute warn_unused_result
OPJFile.cpp:289: warning: ignoring return value of 'size_t fread(void*, size_t,
size_t, FILE*)', declared with attribute warn_unused_result
OPJFile.cpp:298: warning: ignoring return value of 'size_t fread(void*, size_t,
size_t, FILE*)', declared with attribute warn_unused_result
OPJFile.cpp:305: warning: ignoring return value of 'size_t fread(void*, size_t,
size_t, FILE*)', declared with attribute warn_unused_result
OPJFile.cpp:321: warning: ignoring return value of 'size_t fread(void*, size_t,
size_t, FILE*)', declared with attribute warn_unused_result
OPJFile.cpp:323: warning: ignoring return value of 'size_t fread(void*, size_t,
size_t, FILE*)', declared with attribute warn_unused_result
OPJFile.cpp:324: warning: ignoring return value of 'size_t fread(void*, size_t,
size_t, FILE*)', declared with attribute warn_unused_result
OPJFile.cpp:326: warning: ignoring return value of 'size_t fread(void*, size_t,
size_t, FILE*)', declared with attribute warn_unused_result
OPJFile.cpp:328: warning: ignoring return value of 'size_t fread(void*, size_t,
size_t, FILE*)', declared with attribute warn_unused_result
OPJFile.cpp:382: warning: ignoring return value of 'size_t fread(void*, size_t,
size_t, FILE*)', declared with attribute warn_unused_result
OPJFile.cpp:392: warning: ignoring return value of 'size_t fread(void*, size_t,
size_t, FILE*)', declared with attribute warn_unused_result
OPJFile.cpp:408: warning: ignoring return value of 'size_t fread(void*, size_t,
size_t, FILE*)', declared with attribute warn_unused_result
OPJFile.cpp:430: warning: ignoring return value of 'size_t fread(void*, size_t,
size_t, FILE*)', declared with attribute warn_unused_result
OPJFile.cpp:439: warning: ignoring return value of 'size_t fread(void*, size_t,
size_t, FILE*)', declared with attribute warn_unused_result
OPJFile.cpp:475: warning: ignoring return value of 'size_t fread(void*, size_t,
size_t, FILE*)', declared with attribute warn_unused_result
OPJFile.cpp:478: warning: ignoring return value of 'size_t fread(void*, size_t,
size_t, FILE*)', declared with attribute warn_unused_result
g++ -shared -Wl,-soname,liborigin.so.0 -o liborigin.so.0.0.1 OPJFile.o
Added fix for hardcoded path of %{_libdir}
Updated
Spec URL: http://tux.u-strasbg.fr/~chit/RPMS/liborigin.spec
SRPM URL: http://tux.u-strasbg.fr/~chit/RPMS/liborigin-20070115-2.src.rpm
> %{_includedir}/%{name}/OPJFile.h
The directory itself is not included.
GOOD: * Rpmlint silent on both srpm and binaries (No documentation warning on the -devel subpackages, which can be ignored. * Naming meets the guildlines * License - GPL * Source file matches upstream (md5sum: 5ed1c7c0955f935d3b4e45fb25e1d7fc liborigin-20070115.tgz) * Built OK (in rawhide x86_64 mock) * Installs OK and worksforme Please fix the directory listing as Michael pointed out above, and then I can approve the package. Updated Spec URL: http://tux.u-strasbg.fr/~chit/RPMS/liborigin.spec SRPM URL: http://tux.u-strasbg.fr/~chit/RPMS/liborigin-20070115-3.src.rpm APPROVED, with review highlights in comment #4 and update in comment #5 Package Change Request ====================== Package Name: liborigin Short Description: Library for reading OriginLab OPJ project files New Branches: EL-5 EL-6 Owners:chitlesh CVS done (by process-cvs-requests.py). |