Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 2238289

Summary: The default wallpaper is converted to indexed color
Product: [Fedora] Fedora Reporter: Jakub Steiner <jsteiner>
Component: f39-backgroundsAssignee: Adam Williamson <awilliam>
Status: CLOSED ERRATA QA Contact:
Severity: medium Docs Contact:
Priority: unspecified    
Version: rawhideCC: awilliam, luya_tfz
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Linux   
Whiteboard: AcceptedFreezeException
Fixed In Version: f39-backgrounds-39.0.3-1.fc39 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-09-15 18:58:58 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2143445    

Description Jakub Steiner 2023-09-11 09:04:31 UTC 
The default wallpaper is indexed to 8bit color resulting in severe quality degradation with very visible color banding to marginal filesize benefit.

I filed an upstream bug*, but figured the processing is probably happening at package build time.


* https://github.com/fedoradesign/backgrounds/issues/57

Reproducible: Always



Expected Results:  
Specific file format choice, dithering method and color depth is something that needs to be taken depending on the source material. Indexing every PNG into 8bit, however, seems like a wrong choice to 95% of cases.
Comment 1 Adam Williamson 2023-09-11 16:48:16 UTC 
The processing happens in the upstream makefile, which is run at package build time:
https://github.com/fedoradesign/backgrounds/blob/main/default/Makefile#L24
Comment 2 Adam Williamson 2023-09-11 16:49:18 UTC 
It was added in this misleadingly-named commit:
https://github.com/fedoradesign/backgrounds/commit/8226ee7a90ca7b817b64bd2358e96d1ec1b73d1b
Comment 3 Adam Williamson 2023-09-11 17:19:55 UTC 
Proposing as a Beta FE, obviously having an as-intended version of the backgrounds for Beta would be good and cannot be entirely done with an update (you'll see the dithered one on live boots).
Comment 4 Fedora Update System 2023-09-11 22:06:26 UTC 
FEDORA-2023-dcb2b2bb93 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-dcb2b2bb93
Comment 5 Adam Williamson 2023-09-11 22:08:11 UTC 
+3 in https://pagure.io/fedora-qa/blocker-review/issue/1301 , marking accepted FE.
Comment 6 Fedora Update System 2023-09-12 01:24:23 UTC 
FEDORA-2023-dcb2b2bb93 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-dcb2b2bb93`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-dcb2b2bb93

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 7 Fedora Update System 2023-09-13 02:51:40 UTC 
FEDORA-2023-dcb2b2bb93 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-dcb2b2bb93`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-dcb2b2bb93

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 8 Fedora Update System 2023-09-15 18:58:58 UTC 
FEDORA-2023-dcb2b2bb93 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.