Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 224413 (pear-Console-Color)
Summary: | Review Request: php-pear-Console-Color - Easily use ANSI console colors from PHP applications | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Tim Jackson <rpm> |
Component: | Package Review | Assignee: | Christopher Stone <chris.stone> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora |
Target Milestone: | --- | Flags: | kevin:
fedora-cvs+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2007-01-26 21:03:23 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Tim Jackson
2007-01-25 16:29:50 UTC
==== REVIEW CHECKLIST ==== - rpmlint output clean - package named according to package naming guidelines - spec file name matches %{name} - package meets packaging guidelines - licensed with open source compatible license - license field matches actual license - source package does not include license text - spec written in American english - spec file is legible - sources match upstream 0ed565fb5b3f3ed2d604053d9e1adce6 Console_Color-1.0.1.tgz - package successfully compiles and builds on FC-6 x86_64 - all build dependencies listed in BR - no locales - no shared libraries - package is not relocatable X package does not own all directories it creates - directories it does not create are pulled in from other packages - no duplicates in %files - file permissions set properly - contains proper %clean section - macro usage consistent - contains code - no large documentation - %doc does not affect runtime - no header files or static libraries - no pkgconfig files - no library files with suffixes - no need for devel subpackage - no libtool archives - not a GUI app - package does not own files or directories owned by other non-pear packages ==== MUST FIX ==== - This package must own the Console directory ==== SHOULD FIX ==== - Consider adding a PHP License text file to %doc oops, I just realized the Console directory is owned by php-pear, so this package is correct and should *not* own this directory. Ignore the MUST FIX item above. APPROVED Yes, I specifically avoided owning the Console directory for the reason you cite. Upstream doesn't have a License file but http://pear.php.net/bugs/bug.php?id=9948 is an upstream bug about this. Thanks for your time in doing this review. It will be imported ASAP. Built in devel (job #26375) and FC-6 (#26443). Package Change Request ====================== Package Name: php-pear-Console-Color New Branches: el6 Owners: remi Git done (by process-git-requests). |