Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 225341 (pear-CodeSniffer)
| Summary: | Review Request: php-pear-PHP-CodeSniffer - PHP coding standards enforcement tool | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Konstantin Ryabitsev <icon> |
| Component: | Package Review | Assignee: | Christopher Stone <chris.stone> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora |
| Target Milestone: | --- | Flags: | kevin:
fedora-cvs+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-03-14 01:09:54 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779 | ||
|
Description
Konstantin Ryabitsev
2007-01-29 23:16:47 UTC
==== REVIEW CHECKLIST ====
- rpmlint output clean
X package is not named according to package naming guidelines
- spec file name matches %{name}
- package meets packaging guideliens
- licensed with open source compatible license
- license in spec matches actual license
- license file included in %doc
- spec written in American english
- spec file legible
- sources match upstream
9b13c0cad263a1e7044b8135b37a1c93 PHP_CodeSniffer-0.3.0.tgz
- successfully compiles and builds on FC-6 x86_64
- all build dependencies listed in BR
- no locales
- no shared libraries
- not relocatable
X package does not own all directories it creates
- no duplicates in %files
- file permissions set properly
- contains proper %clean
- macro usage is consistent
- contains code
- no large documentation
- %doc does not affect runtime
- no header files or static libraries
- no pkgconfig files
- no library files with suffix
- no need for devel subpackage
- no libtool archives
- not a GUI application
- does not own files or directories owned by other packages
==== MUST FIX ====
- Package must meet packaging naming guidelines, rename package to:
php-pear-PHP-CodeSniffer
- Rename %{name} accordingly
- Package must own all directories it creates:
change %{pear_phpdir}/PHP/* to %{pear_phpdir}/PHP in %files
==== SHOULD FIX ====
- URL should not contain a macro as it is copy&pasted from spec file by
maintainers on a regular basis
- Add versioned Requires: php > 5.1.0
Updated: http://blues.mcgill.ca/~icon/fe/php-pear-PHP-CodeSniffer.spec http://blues.mcgill.ca/~icon/fe/php-pear-PHP-CodeSniffer-0.3.0-1.src.rpm All MUST FIX items fixed. APPROVED Looks like this was build okay, I'm closing this bug. Please close your bugs after package is built. Package Change Request ====================== Package Name: php-pear-PHP-CodeSniffer New Branches: EL-5 branch done. Package Change Request ====================== Package Name: php-pear-PHP-CodeSniffer New Branches: epel7 Owners: remi Git done (by process-git-requests). |